Uh oh!
There was an error while loading. Please reload this page.
Consolidate and document SQL AST shims - #22094
Merged
Merged
Conversation
andygrove
approved these changes
May 10, 2026
alamb
marked this pull request as ready for review
May 11, 2026 12:52
alamb
commented
May 11, 2026
| } | ||
| } | ||
| #[derive(Clone, PartialEq, Eq, PartialOrd, Hash, Debug)] |
ContributorAuthor
There was a problem hiding this comment.
this stuff is all moved to sql.rs and I put a module level comment on it
timsaucer
approved these changes
May 11, 2026
timsaucer
left a comment
Member
There was a problem hiding this comment.
This is a nice cleanup, and something I wasn't 100% happy with when I did it. Thank you!
alamb
commented
May 11, 2026
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| //! Local copies of [`sqlparser::ast`] structures |
ContributorAuthor
There was a problem hiding this comment.
this is the documentation that explains what is going on
alamb
enabled auto-merge
May 11, 2026 13:17
ContributorAuthor
Since I think this will conflict with @andygrove 's upgrade of sqlparser and I don't think it will be potentially controversial, I am mergeing now |
…fusion into alamb/comments_about_sql_copy
github-merge-queueBot
removed this pull request from the merge queue due to no response for status checks
May 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
May 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
May 11, 2026
ContributorAuthor
Merge was failing due to |
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
May 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
May 12, 2026
ContributorAuthor
Thanks @xudong963 |
gstvg pushed a commit
to gstvg/arrow-datafusion
that referenced
this pull request
May 14, 2026
## Which issue does this PR close? - Related to apache#22069 ## Rationale for this change While upgrading sqlparser, it was not clear why there were feature gates for the `sql` feature: https://github.com/apache/datafusion/pull/22069/changes#r3204705488 There is a mode to avoid the `sqlparser` dependency, added by @timsaucer in - apache#17332 I think this feature makes sense but it is a little hard to understand because it is implemented with a bunch of `#[cfg(not(feature = "sql"))]` and there is no central place that explains the design. ## What changes are included in this PR? 1. Consolidate the SQL AST shim structures in a separate module 2. Document the design so it is easier to understand ## Are these changes tested? Yes by CI ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While upgrading sqlparser, it was not clear why there were feature gates for the
sqlfeature: https://github.com/apache/datafusion/pull/22069/changes#r3204705488There is a mode to avoid the
sqlparserdependency, added by @timsaucer insqlfeature to make sql planning optional #17332I think this feature makes sense but it is a little hard to understand because it is implemented with a bunch of
#[cfg(not(feature = "sql"))]and there is no central place that explains the design.What changes are included in this PR?
Are these changes tested?
Yes by CI
Are there any user-facing changes?