Uh oh!
There was an error while loading. Please reload this page.
test: add more tests and docs for heap size estimation - #22358
Merged
Conversation
mkleen
commented
May 19, 2026
| /// This is a temporary solution until <https://github.com/apache/datafusion/pull/19599> and | ||
| /// <https://github.com/apache/arrow-rs/pull/9138> are resolved. | ||
| /// Trait for calculating the size of various containers | ||
| /// Trait for computing how many bytes a value has allocated on the heap. |
ContributorAuthor
There was a problem hiding this comment.
I removed this now because the heapsize estimations in Datafusion already diverged from the once in arrow-rs and there is a good chance that this code continues to live here.
ContributorAuthor
@kosiew Could you maybe have a quick look since you are familiar with the original pr? |
kosiew
requested changes
May 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
mkleen
commented
May 21, 2026
ContributorAuthor
@kosiew Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None.
Rationale for this change
This is a follow-up for #20047 improving docs and test coverage for the heap size estimation.
What changes are included in this PR?
See above.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.