Uh oh!
There was an error while loading. Please reload this page.
Rich t kid/implement multi dictionary aggr - #22983
Conversation
Rich-T-kid
left a comment
There was a problem hiding this comment.
alot of minor things to clean up.
notably most of the logic here isn't too specific to dictionary arrays besides caching the values pointer. we need benchmarks to determine if this is worth approaching over a generic implementation like GroupValueRows
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Rich-T-kid
commented
Jun 18, 2026
going through this now |
c6c4c5b to
d03f712Compared03f712 to
ef4ba19Compare…for key-tuple cache
Still iterating on the PR, these are loose ideas for optimizations (intern path)use VecDeque instead of Vec
adjust the row-tuple cache to be configurable
avoid current double allocation spent for option
bitpack key-tuples cache
|
Rich-T-kid
commented
Jun 23, 2026
see context as to why this isnt being pursued further #21765 (comment) |
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?