Skip to content

Rich t kid/implement multi dictionary aggr#22983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rich-T-kid wants to merge 5 commits into from
Closed

Rich t kid/implement multi dictionary aggr #22983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ff4ccc
working draft
Rich-T-kid Jun 16, 2026
16f74f5
inital draft
Rich-T-kid Jun 16, 2026
dde196b
revised first draft
Rich-T-kid Jun 18, 2026
ef4ba19
introduce key caching
Rich-T-kid Jun 22, 2026
17decbd
add better naming conventions as well as account for memory taken up …
Rich-T-kid Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions datafusion/physical-plan/src/aggregates/group_values/mod.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@ pub use row::GroupValuesRows;
mod single_group_by;
use datafusion_physical_expr::binary_map::OutputType;
use multi_group_by::GroupValuesColumn;
use multi_group_by::dict::{GroupDictionaryColumn, supported_dictionary_schema};

pub(crate) use single_group_by::primitive::HashValue;

Expand DownExpand Up@@ -200,6 +201,11 @@ pub fn new_group_values(
}
}

// Route 2+ all-dictionary columns to the specialised implementation.
if schema.fields().len() >= 2 && supported_dictionary_schema(schema.as_ref()) {
return Ok(Box::new(GroupDictionaryColumn::new(schema)?));
}

if multi_group_by::supported_schema(schema.as_ref()) {
if matches!(group_ordering, GroupOrdering::None) {
Ok(Box::new(GroupValuesColumn::<false>::try_new(schema)?))
Expand Down
Loading
Loading