Uh oh!
There was an error while loading. Please reload this page.
test: cover float IN list predicates - #23373
Merged
Merged
Conversation
alambforce-pushed
the
codex/in-list-float-slt-coverage
branch
from
July 7, 2026 12:24
5484864 to
71a7ca7Comparealambforce-pushed
the
codex/in-list-float-slt-coverage
branch
from
July 7, 2026 12:33
71a7ca7 to
d632a0cComparealambforce-pushed
the
codex/in-list-float-slt-coverage
branch
from
July 7, 2026 12:35
d632a0c to
7b549f5Comparealamb
marked this pull request as ready for review
July 7, 2026 12:35
timsaucer
approved these changes
Jul 7, 2026
alamb
commented
Jul 7, 2026
ContributorAuthor
Thanks @timsaucer -- since this is a test only I'll just merge it in |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As @geoffreyclaude adds additional special implementations for IN lists we should keep up with slt test coverage. Recently we added coverage for floats
What changes are included in this PR?
This adds sqllogictest coverage for Float16, Float32, and Float64
INlist predicates inin_list.slt, mirroring the existing integerINlist coverage shape:Are these changes tested?
Yes -- all tests
Are there any user-facing changes?
No. This only adds test coverage.