Skip to content

test: More slt tests for iszero function - #23713

Merged
2010YOUY01 merged 1 commit into
apache:mainfrom
2010YOUY01:test-iszero
Jul 21, 2026
Merged

test: More slt tests for iszero function#23713
2010YOUY01 merged 1 commit into
apache:mainfrom
2010YOUY01:test-iszero

Conversation

@2010YOUY01

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

With test coverage tool added in #23336, it's easy to identify files that are missing test coverage.

This PR adds test to one of them.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added the sqllogictest SQL Logic Tests (.slt) label Jul 20, 2026
@codecov-commenter

codecov-commenter commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.71%. Comparing base (67947b6) to head (d7a1f4e).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #23713 +/- ##
==========================================
+ Coverage 80.67% 80.71% +0.03% 
==========================================
Files 1088 1088 Lines 367591 367741 +150 Branches 367591 367741 +150 ==========================================
+ Hits 296563 296817 +254 + Misses 53374 53211 -163 - Partials 17654 17713 +59 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2010YOUY01

Copy link
Copy Markdown
ContributorAuthor

main:
image
PR:
image

I'll try to figure out how to let the bot display such changes by default.

@2010YOUY01
2010YOUY01 added this pull request to the merge queueJul 21, 2026
Merged via the queue into apache:main with commit 050046aJul 21, 2026
37 checks passed
@2010YOUY01
2010YOUY01 deleted the test-iszero branch July 21, 2026 10:03
kosiew pushed a commit to kosiew/datafusion that referenced this pull request Aug 12, 2026
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closesapache#123` indicates that this PR will close issue apache#123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
With test coverage tool added in
apache#23336, it's easy to identify
files that are missing test coverage.
This PR adds test to one of them.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictestSQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@2010YOUY01@codecov-commenter@Jefffrey