Skip to content

chore(OrderedFinalAggregateStream): refactor to async generator - #24008

Open
rluvaton wants to merge 6 commits into
apache:mainfrom
rluvaton:move-ordered-final-stream-to-generators
Open

chore(OrderedFinalAggregateStream): refactor to async generator#24008
rluvaton wants to merge 6 commits into
apache:mainfrom
rluvaton:move-ordered-final-stream-to-generators

Conversation

@rluvaton

@rluvatonrluvaton commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Which issue does this PR close?

Related to:

Rationale for this change

Avoid a lot of states that exists only for Poll mechanism, and cleanup the code

What changes are included in this PR?

refactor code to use async generators

Are these changes tested?

Existing tests

Are there any user-facing changes?

No

@github-actionsgithub-actionsBot added the physical-plan Changes to the physical-plan crate label Jul 30, 2026
@rluvatonrluvaton mentioned this pull request Jul 30, 2026
Open
13 tasks
@rluvatonrluvaton changed the title chore(OrderedFinalAggregateStream): refactor to async generatorchore(OrderedFinalAggregateStream): refactor to async generatorJul 30, 2026
@rluvaton
rluvaton marked this pull request as ready for review July 30, 2026 18:24
@rluvaton

rluvaton commented Jul 30, 2026

Copy link
Copy Markdown
MemberAuthor

@2010YOUY01 can you please review?

@rluvaton

rluvaton commented Jul 30, 2026

Copy link
Copy Markdown
MemberAuthor

run benchmark tpcds

@adriangbot

adriangbot commented Jul 30, 2026

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance:c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5134733103-1308-h6xkz 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected

Comparing move-ordered-final-stream-to-generators (478a772) to 541caab (merge-base) diff using: tpcds
Results will be posted here when complete

File an issue against this benchmark runner

@adriangbot

adriangbot commented Jul 30, 2026

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance:c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
Details

Comparing HEAD and move-ordered-final-stream-to-generators
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ move-ordered-final-stream-to-generators ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 5.36 / 5.88 ±0.92 / 7.72 ms │ 5.56 / 6.13 ±0.96 / 8.05 ms │ no change │
│ QQuery 2 │ 80.47 / 80.96 ±0.40 / 81.62 ms │ 80.57 / 81.07 ±0.36 / 81.67 ms │ no change │
│ QQuery 3 │ 29.61 / 29.80 ±0.15 / 29.97 ms │ 29.77 / 29.99 ±0.17 / 30.21 ms │ no change │
│ QQuery 4 │ 481.08 / 483.68 ±2.29 / 486.59 ms │ 480.74 / 483.39 ±2.81 / 488.05 ms │ no change │
│ QQuery 5 │ 52.46 / 55.62 ±4.62 / 64.63 ms │ 53.23 / 55.65 ±4.66 / 64.97 ms │ no change │
│ QQuery 6 │ 36.06 / 36.32 ±0.22 / 36.69 ms │ 36.79 / 37.32 ±0.50 / 38.03 ms │ no change │
│ QQuery 7 │ 93.91 / 94.88 ±1.09 / 96.95 ms │ 95.62 / 96.33 ±0.67 / 97.43 ms │ no change │
│ QQuery 8 │ 36.81 / 39.21 ±3.00 / 45.07 ms │ 36.94 / 38.75 ±2.42 / 43.47 ms │ no change │
│ QQuery 9 │ 51.48 / 54.79 ±2.37 / 58.40 ms │ 52.01 / 54.98 ±2.21 / 57.68 ms │ no change │
│ QQuery 10 │ 62.98 / 63.81 ±0.67 / 64.80 ms │ 63.73 / 64.02 ±0.22 / 64.30 ms │ no change │
│ QQuery 11 │ 296.26 / 298.72 ±2.98 / 304.51 ms │ 297.57 / 303.17 ±4.25 / 310.64 ms │ no change │
│ QQuery 12 │ 28.43 / 29.03 ±0.36 / 29.50 ms │ 28.73 / 29.15 ±0.48 / 30.08 ms │ no change │
│ QQuery 13 │ 118.58 / 119.17 ±0.43 / 119.62 ms │ 119.58 / 119.95 ±0.32 / 120.47 ms │ no change │
│ QQuery 14 │ 413.49 / 416.88 ±3.40 / 422.99 ms │ 416.06 / 419.43 ±2.11 / 421.86 ms │ no change │
│ QQuery 15 │ 57.27 / 57.88 ±0.61 / 58.77 ms │ 57.44 / 58.02 ±0.62 / 59.11 ms │ no change │
│ QQuery 16 │ 6.48 / 6.63 ±0.19 / 7.00 ms │ 6.62 / 6.77 ±0.22 / 7.19 ms │ no change │
│ QQuery 17 │ 80.21 / 81.13 ±0.75 / 82.48 ms │ 80.01 / 80.85 ±0.75 / 82.13 ms │ no change │
│ QQuery 18 │ 124.83 / 127.00 ±2.32 / 130.10 ms │ 122.90 / 123.42 ±0.46 / 124.18 ms │ no change │
│ QQuery 19 │ 41.87 / 42.54 ±0.45 / 43.27 ms │ 41.92 / 42.29 ±0.26 / 42.73 ms │ no change │
│ QQuery 20 │ 35.50 / 35.94 ±0.38 / 36.62 ms │ 35.90 / 36.72 ±0.92 / 38.45 ms │ no change │
│ QQuery 21 │ 17.54 / 18.48 ±1.46 / 21.36 ms │ 17.52 / 17.87 ±0.23 / 18.15 ms │ no change │
│ QQuery 22 │ 62.79 / 63.64 ±0.67 / 64.60 ms │ 62.87 / 65.93 ±3.26 / 72.13 ms │ no change │
│ QQuery 23 │ 344.02 / 347.00 ±2.92 / 352.58 ms │ 347.44 / 349.53 ±1.52 / 351.91 ms │ no change │
│ QQuery 24 │ 224.61 / 226.25 ±1.46 / 228.42 ms │ 225.56 / 227.85 ±2.17 / 230.85 ms │ no change │
│ QQuery 25 │ 110.69 / 112.13 ±1.27 / 114.28 ms │ 110.96 / 112.09 ±0.96 / 113.72 ms │ no change │
│ QQuery 26 │ 57.96 / 59.48 ±2.73 / 64.94 ms │ 58.49 / 60.05 ±2.12 / 64.24 ms │ no change │
│ QQuery 27 │ 6.30 / 6.43 ±0.13 / 6.68 ms │ 6.22 / 6.35 ±0.16 / 6.66 ms │ no change │
│ QQuery 28 │ 56.75 / 61.01 ±2.43 / 64.10 ms │ 57.72 / 60.45 ±2.16 / 63.43 ms │ no change │
│ QQuery 29 │ 96.44 / 98.00 ±1.09 / 99.48 ms │ 97.42 / 101.69 ±6.06 / 113.67 ms │ no change │
│ QQuery 30 │ 32.51 / 35.01 ±3.09 / 41.02 ms │ 32.70 / 33.10 ±0.29 / 33.52 ms │ +1.06x faster │
│ QQuery 31 │ 111.65 / 112.23 ±0.64 / 113.23 ms │ 111.97 / 113.02 ±1.70 / 116.39 ms │ no change │
│ QQuery 32 │ 20.09 / 20.72 ±0.41 / 21.30 ms │ 20.34 / 20.93 ±0.50 / 21.74 ms │ no change │
│ QQuery 33 │ 37.99 / 38.12 ±0.12 / 38.34 ms │ 38.20 / 38.75 ±0.33 / 39.19 ms │ no change │
│ QQuery 34 │ 9.91 / 11.20 ±2.15 / 15.47 ms │ 9.83 / 10.16 ±0.24 / 10.55 ms │ +1.10x faster │
│ QQuery 35 │ 72.92 / 74.05 ±0.77 / 75.24 ms │ 73.48 / 74.87 ±1.04 / 76.20 ms │ no change │
│ QQuery 36 │ 5.86 / 6.06 ±0.22 / 6.47 ms │ 5.93 / 6.10 ±0.21 / 6.52 ms │ no change │
│ QQuery 37 │ 7.01 / 7.06 ±0.05 / 7.12 ms │ 6.88 / 6.93 ±0.04 / 6.97 ms │ no change │
│ QQuery 38 │ 61.57 / 62.14 ±0.43 / 62.74 ms │ 62.20 / 62.43 ±0.32 / 63.06 ms │ no change │
│ QQuery 39 │ 89.04 / 91.44 ±2.81 / 96.94 ms │ 90.92 / 91.88 ±1.23 / 94.08 ms │ no change │
│ QQuery 40 │ 23.37 / 23.81 ±0.32 / 24.27 ms │ 23.29 / 23.73 ±0.37 / 24.37 ms │ no change │
│ QQuery 41 │ 11.55 / 11.73 ±0.25 / 12.21 ms │ 11.56 / 11.80 ±0.24 / 12.20 ms │ no change │
│ QQuery 42 │ 24.20 / 24.45 ±0.19 / 24.76 ms │ 24.02 / 24.52 ±0.57 / 25.59 ms │ no change │
│ QQuery 43 │ 4.97 / 5.08 ±0.12 / 5.32 ms │ 4.98 / 5.09 ±0.11 / 5.25 ms │ no change │
│ QQuery 44 │ 9.16 / 9.26 ±0.08 / 9.39 ms │ 9.20 / 9.34 ±0.12 / 9.50 ms │ no change │
│ QQuery 45 │ 37.37 / 38.55 ±0.60 / 39.07 ms │ 38.08 / 38.43 ±0.22 / 38.63 ms │ no change │
│ QQuery 46 │ 11.78 / 12.08 ±0.20 / 12.30 ms │ 11.74 / 12.62 ±1.57 / 15.76 ms │ no change │
│ QQuery 47 │ 227.90 / 229.51 ±1.67 / 231.62 ms │ 225.74 / 230.54 ±3.00 / 234.05 ms │ no change │
│ QQuery 48 │ 96.11 / 99.41 ±3.90 / 107.07 ms │ 97.06 / 97.51 ±0.33 / 97.90 ms │ no change │
│ QQuery 49 │ 77.20 / 77.63 ±0.38 / 78.31 ms │ 77.05 / 78.18 ±1.37 / 80.74 ms │ no change │
│ QQuery 50 │ 59.31 / 61.01 ±2.57 / 66.00 ms │ 59.34 / 60.39 ±0.87 / 61.97 ms │ no change │
│ QQuery 51 │ 91.64 / 94.00 ±2.90 / 99.58 ms │ 91.88 / 93.44 ±0.88 / 94.49 ms │ no change │
│ QQuery 52 │ 23.92 / 24.32 ±0.44 / 25.14 ms │ 24.20 / 24.54 ±0.20 / 24.74 ms │ no change │
│ QQuery 53 │ 29.37 / 29.66 ±0.27 / 30.15 ms │ 30.03 / 32.09 ±2.74 / 37.48 ms │ 1.08x slower │
│ QQuery 54 │ 55.12 / 57.49 ±3.66 / 64.72 ms │ 55.87 / 57.22 ±1.33 / 59.73 ms │ no change │
│ QQuery 55 │ 23.59 / 24.39 ±0.48 / 25.06 ms │ 23.53 / 24.13 ±0.68 / 25.41 ms │ no change │
│ QQuery 56 │ 39.11 / 39.59 ±0.67 / 40.90 ms │ 39.59 / 40.05 ±0.35 / 40.58 ms │ no change │
│ QQuery 57 │ 178.21 / 179.48 ±1.40 / 181.81 ms │ 178.03 / 180.17 ±2.47 / 184.28 ms │ no change │
│ QQuery 58 │ 114.95 / 116.29 ±1.09 / 117.57 ms │ 116.38 / 118.31 ±2.24 / 122.19 ms │ no change │
│ QQuery 59 │ 118.60 / 119.31 ±1.14 / 121.59 ms │ 118.02 / 118.57 ±0.44 / 119.35 ms │ no change │
│ QQuery 60 │ 39.78 / 40.54 ±0.75 / 41.69 ms │ 39.68 / 40.46 ±0.58 / 41.23 ms │ no change │
│ QQuery 61 │ 12.08 / 12.22 ±0.17 / 12.55 ms │ 12.37 / 13.47 ±2.00 / 17.46 ms │ 1.10x slower │
│ QQuery 62 │ 46.36 / 48.05 ±2.93 / 53.87 ms │ 46.63 / 46.76 ±0.16 / 47.03 ms │ no change │
│ QQuery 63 │ 29.83 / 30.68 ±0.67 / 31.70 ms │ 30.34 / 31.43 ±1.02 / 33.31 ms │ no change │
│ QQuery 64 │ 407.96 / 413.87 ±6.15 / 425.02 ms │ 411.22 / 414.40 ±1.71 / 416.16 ms │ no change │
│ QQuery 65 │ 126.06 / 127.54 ±0.83 / 128.36 ms │ 126.70 / 127.81 ±0.74 / 128.58 ms │ no change │
│ QQuery 66 │ 80.78 / 84.74 ±4.40 / 92.83 ms │ 80.55 / 81.37 ±1.30 / 83.97 ms │ no change │
│ QQuery 67 │ 239.74 / 245.79 ±5.30 / 253.40 ms │ 237.47 / 244.59 ±7.63 / 259.34 ms │ no change │
│ QQuery 68 │ 11.94 / 12.18 ±0.22 / 12.51 ms │ 11.89 / 12.04 ±0.21 / 12.45 ms │ no change │
│ QQuery 69 │ 57.40 / 57.61 ±0.17 / 57.85 ms │ 57.77 / 60.21 ±2.50 / 63.36 ms │ no change │
│ QQuery 70 │ 106.96 / 109.58 ±2.79 / 114.54 ms │ 107.41 / 109.63 ±1.79 / 111.38 ms │ no change │
│ QQuery 71 │ 35.72 / 36.02 ±0.19 / 36.30 ms │ 36.36 / 36.70 ±0.28 / 37.18 ms │ no change │
│ QQuery 72 │ 2002.67 / 2117.61 ±63.36 / 2181.94 ms │ 2116.71 / 2220.16 ±58.74 / 2289.08 ms │ no change │
│ QQuery 73 │ 9.73 / 10.39 ±1.03 / 12.41 ms │ 9.63 / 12.36 ±4.95 / 22.25 ms │ 1.19x slower │
│ QQuery 74 │ 169.51 / 172.37 ±3.58 / 178.89 ms │ 171.46 / 174.14 ±3.02 / 178.14 ms │ no change │
│ QQuery 75 │ 148.76 / 150.15 ±1.14 / 151.89 ms │ 151.45 / 155.49 ±4.11 / 163.26 ms │ no change │
│ QQuery 76 │ 35.23 / 37.77 ±4.30 / 46.34 ms │ 35.87 / 36.18 ±0.28 / 36.67 ms │ no change │
│ QQuery 77 │ 61.73 / 62.47 ±0.49 / 63.07 ms │ 62.17 / 64.50 ±3.66 / 71.79 ms │ no change │
│ QQuery 78 │ 199.88 / 203.02 ±4.34 / 211.55 ms │ 198.20 / 203.74 ±4.74 / 211.27 ms │ no change │
│ QQuery 79 │ 67.95 / 68.98 ±1.99 / 72.96 ms │ 68.73 / 69.71 ±0.83 / 71.21 ms │ no change │
│ QQuery 80 │ 100.74 / 104.82 ±4.33 / 112.44 ms │ 100.46 / 101.34 ±1.20 / 103.70 ms │ no change │
│ QQuery 81 │ 25.73 / 26.07 ±0.29 / 26.57 ms │ 26.04 / 27.70 ±3.12 / 33.94 ms │ 1.06x slower │
│ QQuery 82 │ 16.35 / 16.86 ±0.53 / 17.78 ms │ 17.07 / 18.78 ±3.12 / 25.01 ms │ 1.11x slower │
│ QQuery 83 │ 39.73 / 41.18 ±2.47 / 46.10 ms │ 40.34 / 41.60 ±1.44 / 44.26 ms │ no change │
│ QQuery 84 │ 30.16 / 30.35 ±0.20 / 30.73 ms │ 30.31 / 30.69 ±0.36 / 31.31 ms │ no change │
│ QQuery 85 │ 106.17 / 109.75 ±4.76 / 119.16 ms │ 106.85 / 108.47 ±1.78 / 111.85 ms │ no change │
│ QQuery 86 │ 25.43 / 25.86 ±0.23 / 26.06 ms │ 25.21 / 26.58 ±1.88 / 30.30 ms │ no change │
│ QQuery 87 │ 62.13 / 63.16 ±0.86 / 64.68 ms │ 62.95 / 63.49 ±0.60 / 64.54 ms │ no change │
│ QQuery 88 │ 63.82 / 64.91 ±1.98 / 68.87 ms │ 64.06 / 64.46 ±0.32 / 64.89 ms │ no change │
│ QQuery 89 │ 36.45 / 37.38 ±1.37 / 40.09 ms │ 36.82 / 37.84 ±1.42 / 40.63 ms │ no change │
│ QQuery 90 │ 17.24 / 17.37 ±0.10 / 17.51 ms │ 17.29 / 17.72 ±0.26 / 17.98 ms │ no change │
│ QQuery 91 │ 45.57 / 45.93 ±0.30 / 46.32 ms │ 46.07 / 46.63 ±0.56 / 47.62 ms │ no change │
│ QQuery 92 │ 29.38 / 30.11 ±0.45 / 30.61 ms │ 29.62 / 30.15 ±0.42 / 30.90 ms │ no change │
│ QQuery 93 │ 50.14 / 51.06 ±0.50 / 51.47 ms │ 49.92 / 51.03 ±0.83 / 52.48 ms │ no change │
│ QQuery 94 │ 39.02 / 41.05 ±2.90 / 46.68 ms │ 38.24 / 38.69 ±0.38 / 39.37 ms │ +1.06x faster │
│ QQuery 95 │ 81.89 / 83.40 ±1.63 / 85.67 ms │ 81.53 / 83.32 ±2.38 / 87.97 ms │ no change │
│ QQuery 96 │ 24.29 / 24.47 ±0.15 / 24.70 ms │ 24.48 / 24.65 ±0.17 / 24.97 ms │ no change │
│ QQuery 97 │ 47.28 / 47.53 ±0.19 / 47.81 ms │ 47.04 / 47.67 ±0.43 / 48.17 ms │ no change │
│ QQuery 98 │ 43.62 / 44.73 ±1.88 / 48.48 ms │ 42.60 / 43.13 ±0.46 / 43.81 ms │ no change │
│ QQuery 99 │ 70.44 / 71.10 ±0.72 / 72.49 ms │ 70.33 / 71.71 ±1.47 / 74.51 ms │ no change │
└───────────┴───────────────────────────────────────┴─────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 9906.05ms │
│ Total Time (move-ordered-final-stream-to-generators) │ 10038.87ms │
│ Average Time (HEAD) │ 100.06ms │
│ Average Time (move-ordered-final-stream-to-generators) │ 101.40ms │
│ Queries Faster │ 3 │
│ Queries Slower │ 5 │
│ Queries with No Change │ 91 │
│ Queries with Failure │ 0 │
└────────────────────────────────────────────────────────┴────────────┘

Resource Usage

tpcds — base (merge-base)

MetricValue
Wall time50.0s
Peak memory2.2 GiB
Avg memory1.6 GiB
CPU user219.8s
CPU sys6.1s
Peak spill0 B

tpcds — branch

MetricValue
Wall time55.0s
Peak memory2.2 GiB
Avg memory1.5 GiB
CPU user227.4s
CPU sys6.4s
Peak spill0 B

File an issue against this benchmark runner

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.85%. Comparing base (541caab) to head (a7d2853).
⚠️ Report is 4 commits behind head on main.

Files with missing linesPatch %Lines
...ysical-plan/src/aggregates/ordered_final_stream.rs81.65%7 Missing and 13 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #24008 +/- ##
==========================================
+ Coverage 80.84% 80.85% +0.01% 
==========================================
Files 1096 1098 +2 Lines 373936 374087 +151 Branches 373936 374087 +151 ==========================================
+ Hits 302313 302486 +173 + Misses 53584 53548 -36 - Partials 18039 18053 +14

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rluvatonrluvaton mentioned this pull request Jul 30, 2026
Open
16 tasks
@rluvaton
rluvaton requested a review from 2010YOUY01July 30, 2026 19:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2010YOUY012010YOUY01Awaiting requested review from 2010YOUY01

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

physical-planChanges to the physical-plan crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rluvaton@adriangbot@codecov-commenter