Uh oh!
There was an error while loading. Please reload this page.
WindowTopN dense_rank benchmark - #24050
Merged
kumarUjjawal merged 3 commits intoAug 2, 2026
Merged
Conversation
kumarUjjawal
approved these changes
Aug 2, 2026
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a nit.
| -- Window Top-N (DENSE_RANK top-2 per partition, ~100 partitions) | ||
| -- The DENSE_RANK queries below mirror the RANK cardinality sweep above. | ||
| -- DENSE_RANK semantics keep every row whose ORDER BY value is among the | ||
| -- K distinct-smallest values in the partition, so total kept per partition |
Contributor
There was a problem hiding this comment.
nit: should we change the comment to mean greatest value?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #24050 +/- ##
==========================================
- Coverage 80.86% 80.85% -0.01%
==========================================
Files 1101 1101 Lines 375446 375446 Branches 375446 375446 ==========================================
- Hits 303596 303585 -11 - Misses 53757 53765 +8 - Partials 18093 18096 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
commented
Aug 2, 2026
Contributor
Thanks you @SubhamSinghal |
Uh oh!
There was an error while loading. Please reload this page.
kosiew pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
dense_rank benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dense_rank benchmark