Uh oh!
There was an error while loading. Please reload this page.
tests: add SLT test coverage for MERGE INTO - #24174
Merged
Merged
Conversation
alambforce-pushed
the
alamb/merge_into_slt
branch
from
August 7, 2026 20:31
c19f59b to
fffede8Comparealamb
marked this pull request as ready for review
August 7, 2026 20:31
codecov-commenter
commented
Aug 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #24174 +/- ##
=======================================
Coverage 81.06% 81.06% =======================================
Files 1107 1107 Lines 382191 382191 Branches 382191 382191 =======================================
+ Hits 309805 309810 +5 + Misses 54083 54077 -6 - Partials 18303 18304 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
approved these changes
Aug 8, 2026
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @alamb
This is nice 👍
alamb
commented
Aug 8, 2026
ContributorAuthor
Thank you for the review @kumarUjjawal |
Uh oh!
There was an error while loading. Please reload this page.
kosiew pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
## Which issue does this PR close? - Follow on ot apache#22988 from @wirybeaver ## Rationale for this change In addition to planning for MERGE INTO I think we should have some SQL level tests . Since the default MemTable doesn't implement MERGE INTO we can mostly only test the planning, but we should still add the coverage I think ## What changes are included in this PR? Add slt tests for `MERGE INTO`, with mostly explain plan coverage ## Are these changes tested? Only tests ## Are there any user-facing changes? No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In addition to planning for MERGE INTO I think we should have some SQL level tests . Since the default MemTable doesn't implement MERGE INTO we can mostly only test the planning, but we should still add the coverage I think
What changes are included in this PR?
Add slt tests for
MERGE INTO, with mostly explain plan coverageAre these changes tested?
Only tests
Are there any user-facing changes?
No