Skip to content

Add SQL query planner support for time literal - #2884

Closed
andygrove wants to merge 1 commit into
apache:masterfrom
andygrove:time-literal
Closed

Add SQL query planner support for time literal#2884
andygrove wants to merge 1 commit into
apache:masterfrom
andygrove:time-literal

Conversation

@andygrove

@andygroveandygrove commented Jul 12, 2022

Copy link
Copy Markdown
Member

Which issue does this PR close?

Part of #2883

Rationale for this change

Support more SQL in the SQL query planner

What changes are included in this PR?

Add support for TIME literal values in SQL query planner

Are there any user-facing changes?

No

@andygrove
andygrove marked this pull request as draft July 12, 2022 16:21
@github-actionsgithub-actionsBot added the sql SQL Planner label Jul 12, 2022
@andygrove

Copy link
Copy Markdown
MemberAuthor

Converting to draft as this isn't enough.

SELECT TIME '08:08:00.091' AS "T";
Internal("Unsupported CAST from Utf8 to Time32(Millisecond)")

@andygroveandygrove changed the title Add support for time literal in SQLAdd SQL query planner support for time literalJul 12, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #2884 (3b9c2a2) into master (d25e822) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2884 +/- ##
==========================================
+ Coverage 85.25% 85.35% +0.09% 
==========================================
Files 275 276 +1 Lines 49010 49295 +285 ==========================================
+ Hits 41785 42075 +290 + Misses 7225 7220 -5 
Impacted FilesCoverage Δ
datafusion/sql/src/planner.rs81.42% <100.00%> (+0.04%)⬆️
datafusion/expr/src/window_frame.rs92.43% <0.00%> (-0.85%)⬇️
datafusion/common/src/scalar.rs75.77% <0.00%> (-0.12%)⬇️
datafusion/core/tests/sql/timestamp.rs100.00% <0.00%> (ø)
datafusion/physical-expr/src/expressions/mod.rs100.00% <0.00%> (ø)
datafusion/physical-expr/src/expressions/delta.rs100.00% <0.00%> (ø)
datafusion/optimizer/src/simplify_expressions.rs82.00% <0.00%> (+0.02%)⬆️
...tafusion/physical-expr/src/expressions/datetime.rs86.80% <0.00%> (+54.14%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25e822...3b9c2a2. Read the comment docs.

@alamb

Copy link
Copy Markdown
Contributor

Possibly related / redundant with @stuartcarnie 's #3010

@andygrove

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #3010

@andygrove
andygrove deleted the time-literal branch August 15, 2022 18:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqlSQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andygrove@codecov-commenter@alamb