Skip to content

Minor: Clean up array test - #3121

Merged
alamb merged 1 commit into
apache:masterfrom
alamb:alamb/array_test
Aug 15, 2022
Merged

Minor: Clean up array test#3121
alamb merged 1 commit into
apache:masterfrom
alamb:alamb/array_test

Conversation

@alamb

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

re: #3115

Rationale for this change

This test uses an older style of comparison because it was waiting on an upstream fix in arrow

What changes are included in this PR?

Chang the test to Use the same style as the rest of the tests

Are there any user-facing changes?

No

@github-actionsgithub-actionsBot added the core Core DataFusion crate label Aug 13, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3121 (91cf109) into master (b1765f7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #3121 +/- ##
==========================================
- Coverage 85.95% 85.94% -0.02% 
==========================================
Files 291 291 Lines 52382 52378 -4 ==========================================
- Hits 45025 45016 -9 - Misses 7357 7362 +5 
Impacted FilesCoverage Δ
datafusion/core/tests/sql/functions.rs100.00% <100.00%> (ø)
datafusion/core/tests/sql/mod.rs96.94% <0.00%> (-0.85%)⬇️
datafusion/expr/src/logical_plan/plan.rs77.77% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alamb
alamb merged commit ff53f8b into apache:masterAug 15, 2022
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 48f9b7a and contender = ff53f8b. ff53f8b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
alamb deleted the alamb/array_test branch August 8, 2023 20:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb@codecov-commenter@ursabot@liukun4515