impl binary ops between binary arrays and scalars

[ozgrakkurt]

closes#3117

[codecov-commenter]

Codecov Report

Merging #3124 (989f985) into master (3d37016) will decrease coverage by 0.01%.
The diff coverage is 76.84%.

❗ Current head 989f985 differs from pull request most recent head 2f4912a. Consider uploading reports for the commit 2f4912a to get more accurate results

@@ Coverage Diff @@## master #3124 +/- ##
==========================================
- Coverage 85.74% 85.72% -0.02% 
==========================================
Files 294 294 Lines 53770 53852 +82 ==========================================
+ Hits 46104 46165 +61 - Misses 7666 7687 +21 

Impacted Files	Coverage Δ
datafusion/physical-expr/src/expressions/binary.rs	97.71% <ø> (ø)
datafusion/physical-expr/src/crypto_expressions.rs	55.39% <38.23%> (-7.11%)	⬇️
datafusion/expr/src/function.rs	97.47% <93.75%> (-0.28%)	⬇️
datafusion/core/tests/sql/expr.rs	99.87% <100.00%> (+<0.01%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[alamb]

Thank you for the contribution @ozgrakkurt !

Looks like this PR has a clippy errors

Also, can you please add some tests for this? Specifically, it would be great to get an end to end test

Perhaps:

1. make a RecordBatch with a BinaryArray and LargeBinaryArray (like this example: https://github.com/apache/arrow-datafusion/blob/3eb55e9a0510d872f6f7765b1a5f17db46486e45/datafusion/row/src/lib.rs#L351)
2. Write a query that does SELECT binary_col='foo', binary_col = other_binary_col, large_binary_col = 'bar', large_binary_col = other_large_binary_col, following the model https://github.com/apache/arrow-datafusion/blob/834924f274d9e04444030b8eb3e07e1035fcd3cf/datafusion/core/tests/sql/functions.rs#L114-L143

Also, it appears that the fmt CI check has failed: https://github.com/apache/arrow-datafusion/runs/7839919855?check_suite_focus=true

to fix you probably need to run cargo fmt and check it in!

Thank you so much!

[alamb]

It looks like all this PR needs is some tests. @ozgrakkurt is that something you can help with?

[alamb]

Marking as draft while we work on the tests

[ozgrakkurt]

Hey @alamb Sorry for late follow up, I was busy with my full time job,

Currently can't put binary literals into sql. Does creating a logical plan to test this sound ok?
Also where should I put this test?

[alamb]

Hey @alamb Sorry for late follow up, I was busy with my full time job,

I totally understand -- no worries. I was out last week anyways :)

Currently can't put binary literals into sql. Does creating a logical plan to test this sound ok?

I think that would be ok. An alternate would be to use a function that creates a BinaryArray such as sha256. So maybe something like this (untested):

select sha256('foo') = sha256('bar')

[ozgrakkurt]

@alamb apparently sha functions also only accept string. created an issue here: #3308

[ozgrakkurt]

I suggest I add support for binary datatypes to those functions in this PR as well (which should be easy) and create the test using them

[ozgrakkurt]

closes #3308

[ozgrakkurt]

@alamb should be ready to review

[alamb]

Looks good to me

[ozgrakkurt]

@alamb committing fix for digest function signature and formatting errors

[ozgrakkurt]

@alamb sorry, can you review again

[ozgrakkurt]

tests are failing because of #3327

[ozgrakkurt]

@alamb can you merge this when you have time?

[alamb]

Thanks @ozgrakkurt

[ursabot]

Benchmark runs are scheduled for baseline = 8b2fd22 and contender = 24db13b. 24db13b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java