Uh oh!
There was an error while loading. Please reload this page.
Add support for inline column alias in CREATE VIEW - #3209
Conversation
- Add columns argument to planner::query_to_plan - Add columns argument to planner::query_to_plan_with_alias - Add test query_view_with_alias to view.rs - Add test query_view_with_inline_alias to view.rs Resolves #3108 fix(planner): Updated Statement::CreateView logic - Added match for empty columns vector to determine optional value
| } | ||
| #[tokio::test] | ||
| async fn query_view_with_inline_alias() -> Result<()> { |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Andy Grove <andygrove73@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Andy Grove <andygrove73@gmail.com>
alamb
left a comment
There was a problem hiding this comment.
Thank you @DaltonModlin -- I think this is looking good. I think @andygrove 's suggestion on moving the code around would make the code better, but I also think it could be done as a follow on. 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #3209 +/- ##
==========================================
- Coverage 85.85% 85.83% -0.03%
==========================================
Files 291 291 Lines 52899 52947 +48 ==========================================
+ Hits 45416 45446 +30 - Misses 7483 7501 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| .map_err(|e| { | ||
| context!("Failed to apply alias to inline projection.\n", e) | ||
| })? | ||
| .build() |
There was a problem hiding this comment.
This is fine and no need to change this but just an FYI really, you can avoid having multiple map_err like this:
| .map_err(|e| { | |
| context!("Failed to apply alias to inline projection.\n", e) | |
| })? | |
| .build() | |
| .and_then(|builder| builder.build()) |
ursabot
commented
Aug 23, 2022
Benchmark runs are scheduled for baseline = f974e88 and contender = c72f547. c72f547 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Resolves#3108
fix(planner): Updated Statement::CreateView logic
Closes#3108
Rationale for this change
Enables part of TPCH Query 15.
What changes are included in this PR?
Added capability for inline column aliases in sql queries.
Are there any user-facing changes?
Added capability for inline column aliases in sql queries.