Skip to content

support inlist for pre cast literal expression - #3270

Merged
liukun4515 merged 4 commits into
apache:masterfrom
liukun4515:support_inlist_#3031
Aug 30, 2022
Merged

support inlist for pre cast literal expression#3270
liukun4515 merged 4 commits into
apache:masterfrom
liukun4515:support_inlist_#3031

Conversation

@liukun4515

@liukun4515liukun4515 commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

part of #3031

Rationale for this change

What changes are included in this PR?

Support the InList in the PreCastLitInComparisonExpressions optimizer rule

Are there any user-facing changes?

@github-actionsgithub-actionsBot added the optimizer Optimizer rules label Aug 26, 2022
@liukun4515
liukun4515 marked this pull request as ready for review August 26, 2022 06:28
@liukun4515

Copy link
Copy Markdown
ContributorAuthor

@andygrove PTAL, this is a follow-up pr for #3031

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3270 (aa4fe6c) into master (b1db5ff) will increase coverage by 0.02%.
The diff coverage is 97.84%.

@@ Coverage Diff @@## master #3270 +/- ##
==========================================
+ Coverage 85.92% 85.94% +0.02% 
==========================================
Files 294 294 Lines 53442 53536 +94 ==========================================
+ Hits 45919 46012 +93 - Misses 7523 7524 +1 
Impacted FilesCoverage Δ
...fusion/optimizer/src/pre_cast_lit_in_comparison.rs94.00% <97.84%> (+2.05%)⬆️
datafusion/core/src/physical_plan/metrics/value.rs86.93% <0.00%> (-0.51%)⬇️
datafusion/sql/src/planner.rs80.62% <0.00%> (-0.04%)⬇️
datafusion/expr/src/logical_plan/plan.rs78.73% <0.00%> (+0.17%)⬆️
...atafusion/physical-expr/src/expressions/in_list.rs83.56% <0.00%> (+0.39%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygroveandygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liukun4515

@liukun4515
liukun4515 merged commit a4e74c0 into apache:masterAug 30, 2022
@liukun4515
liukun4515 deleted the support_inlist_#3031 branch August 30, 2022 09:48
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 3effee8 and contender = a4e74c0. a4e74c0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizerOptimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@liukun4515@codecov-commenter@ursabot@andygrove