Uh oh!
There was an error while loading. Please reload this page.
Expr variants for boolean operations - #3275
Conversation
Uh oh!
There was an error while loading. Please reload this page.
andygrove
commented
Aug 26, 2022
Thanks @sarahyurick this looks good so far. I created a PR against your branch to fix the protobuf part. https://github.com/sarahyurick/arrow-datafusion/pull/1/files |
sarahyurick
commented
Aug 26, 2022
Awesome, thanks! |
andygrove
commented
Aug 26, 2022
The final piece here is to update the SQL query planner (datafusion/sql/src/planner.rs) so that we map the SQL expressions to these new Logical Plan expressions instead of to |
andygrove
commented
Aug 29, 2022
Actually, one other thing will be to map these new Operator::IsDistinctFrom => {match(left_data_type, right_data_type){// exchange lhs and rhs when lhs is Null, since `binary_array_op` is// always try to down cast array according to $LEFT expression.(DataType::Null, _) => {binary_array_op!(right, left, is_distinct_from)}
_ => binary_array_op!(left, right, is_distinct_from),}} |
On second thoughts, let's handle the physical plan side of this as a follow on PR. I filed #3288 to track this. |
andygrove
left a comment
There was a problem hiding this comment.
Thanks @sarahyurick. Let's go ahead and merge this and then we can follow up with integrating with the SQL query planner and the physical plan.
ursabot
commented
Aug 30, 2022
Benchmark runs are scheduled for baseline = fb2f0db and contender = a32c408. a32c408 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes#3268
Rationale for this change
Hi @andygrove, let me know if this is what you were thinking.