Skip to content

MINOR: add github action trigger - #3323

Merged
alamb merged 3 commits into
apache:masterfrom
waynexia:action-trigger
Sep 1, 2022
Merged

MINOR: add github action trigger#3323
alamb merged 3 commits into
apache:masterfrom
waynexia:action-trigger

Conversation

@waynexia

Copy link
Copy Markdown
Member

Signed-off-by: Ruihang Xia waynestxia@gmail.com

Which issue does this PR close?

Ref #3321.

Rationale for this change

GitHub Action will only run on PR updating, we cannot trigger one on demand manually. This is inconvenient if we want to run one on master or without submitting a PR.

I've tried this patch in my fork repo, now I can see this button:
image

What changes are included in this PR?

Add an [action trigger](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch] that allows us to trigger an action manually.

Are there any user-facing changes?

No

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@andygrove

Copy link
Copy Markdown
Member

test failure caused by #3327

push:
pull_request:
# manual trigger
workflow_dispatch:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread.github/workflows/rust.yml
@alamb

alamb commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @waynexia -- this looks great.

@alamb

alamb commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

I took the liberty of merging this branch to master -- hope to merge it when green

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3323 (9140639) into master (70e702c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3323 +/- ##
==========================================
- Coverage 85.81% 85.81% -0.01% 
==========================================
Files 294 294 Lines 53764 53764 ==========================================
- Hits 46136 46135 -1 - Misses 7628 7629 +1 
Impacted FilesCoverage Δ
datafusion/expr/src/logical_plan/plan.rs78.05% <0.00%> (-0.17%)⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alamb
alamb merged commit e0a765d into apache:masterSep 1, 2022
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 70e702c and contender = e0a765d. e0a765d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@waynexia
waynexia deleted the action-trigger branch September 2, 2022 08:23
@waynexia

Copy link
Copy Markdown
MemberAuthor

Thanks ❤️

kmitchener pushed a commit to kmitchener/datafusion that referenced this pull request Sep 4, 2022
* MINOR: add github action trigger
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
* Update .github/workflows/rust.yml
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@waynexia@andygrove@alamb@codecov-commenter@ursabot