Skip to content

Deprecate legacy datafusion::logical_plan module - #3338

Merged
alamb merged 1 commit into
apache:masterfrom
andygrove:deprecate-core-logical-plan
Sep 3, 2022
Merged

Deprecate legacy datafusion::logical_plan module#3338
alamb merged 1 commit into
apache:masterfrom
andygrove:deprecate-core-logical-plan

Conversation

@andygrove

Copy link
Copy Markdown
Member

Which issue does this PR close?

Part of #2683

Rationale for this change

Part of stabilizing the public API

What changes are included in this PR?

Deprecate the legacy logical_plan module in datafusion "core" crate. This just contains re-exports of other items.

Are there any user-facing changes?

Yes, API change.

@andygroveandygrove added the api change Changes the API exposed to users of the crate label Sep 2, 2022
@github-actionsgithub-actionsBot added the core Core DataFusion crate label Sep 2, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3338 (c37fe23) into master (dadd2dc) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #3338 +/- ##
=======================================
Coverage 85.83% 85.83% =======================================
Files 294 294 Lines 53752 53752 =======================================
Hits 46137 46137 Misses 7615 7615 
Impacted FilesCoverage Δ
datafusion/core/src/dataframe.rs88.91% <ø> (ø)
datafusion/core/src/datasource/listing/helpers.rs95.01% <100.00%> (ø)
datafusion/core/src/physical_optimizer/pruning.rs94.75% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alamb

alamb commented Sep 3, 2022

Copy link
Copy Markdown
Contributor

I merged the code in this PR with the latest apache/master and verified the tests still pass 👍

@alamb
alamb merged commit 93a95c2 into apache:masterSep 3, 2022
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5621e3b and contender = 93a95c2. 93a95c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kmitchener pushed a commit to kmitchener/datafusion that referenced this pull request Sep 4, 2022
@andygrove
andygrove deleted the deprecate-core-logical-plan branch January 27, 2023 18:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api changeChanges the API exposed to users of the cratecoreCore DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@andygrove@codecov-commenter@alamb@ursabot