Uh oh!
There was an error while loading. Please reload this page.
Add SQL support for tinyint , smallint, and unsigned int variants - #3359
Conversation
kmitchener
commented
Sep 5, 2022
I really messed up the previous PR #3309, this replaces that one. Apologies for that. |
codecov-commenter
commented
Sep 5, 2022
Codecov Report
@@ Coverage Diff @@## master #3359 +/- ##
==========================================
+ Coverage 85.51% 85.56% +0.05%
==========================================
Files 294 295 +1 Lines 54120 54112 -8 ==========================================
+ Hits 46279 46303 +24 + Misses 7841 7809 -32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tinyint and unsigned int variantstinyint and unsigned int variantstinyint , smallint, and unsigned int variants
alamb
left a comment
There was a problem hiding this comment.
Looks great -- thank you for sticking with this @kmitchener as we reached consensus.
cc @liukun4515
| async fn register_aggregate_csv_by_sql(ctx: &SessionContext) { | ||
| let testdata = datafusion::test_util::arrow_test_data(); | ||
| // TODO: The following c9 should be migrated to UInt32 and c10 should be UInt64 once |
alamb
commented
Sep 6, 2022
For anyone else following along, additional work is tracked in #3376 |
ursabot
commented
Sep 6, 2022
Benchmark runs are scheduled for baseline = 827cab9 and contender = 751cbc8. 751cbc8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes#3307 and closes#3325.
Rationale for this change
What changes are included in this PR?
Per the issue, this adds the following SQL datatype support:
so now you can use this in
create external table (c1 tinyint, c2 bigint unsigned) ...etc. Also available in cast() SQL:Are there any user-facing changes?