Uh oh!
There was an error while loading. Please reload this page.
Use hash repartitioning for aggregates on dictionaries - #3445
Conversation
codecov-commenter
commented
Sep 11, 2022
Codecov Report
@@ Coverage Diff @@## master #3445 +/- ##
=======================================
Coverage 85.69% 85.69% =======================================
Files 298 298 Lines 54644 54654 +10 =======================================
+ Hits 46826 46836 +10
Misses 7818 7818
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ursabot
commented
Sep 11, 2022
Benchmark runs are scheduled for baseline = 8df5496 and contender = 81addf7. 81addf7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes#331.
Rationale for this change
Hash repartitioning for aggregates on dictionaries was not available when it was initially implemented since dictionaries couldn't be hashed. The real issue in #331 (implementing vectorized hashing for dictionaries) is already resolved (by @alamb on #812), so as far as I can say we can safely remove this guard in the physical plan builder to leverage hash repartitioning on aggregates with dicts.
What changes are included in this PR?
Changes the physical plan builder to use hash repartitioning on dictionary-based aggregates.
Are there any user-facing changes?
This is an optimization, so there shouldn't be any behavioural change but the physical plans will change on some scenerios (like the example below).
Previous physical plan for the test
hash_agg_group_by_partitioned_on_dicts:Current physical plan for it: