Uh oh!
There was an error while loading. Please reload this page.
minor: fix bug in downcast_value! macro (T --> $T) - #3486
Conversation
downcast_value! macrodowncast_value! macro (T --> $T)codecov-commenter
commented
Sep 14, 2022
Codecov Report
@@ Coverage Diff @@## master #3486 +/- ##
=======================================
Coverage 85.75% 85.76% =======================================
Files 299 299 Lines 55282 55282 =======================================
+ Hits 47409 47410 +1 + Misses 7873 7872 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ursabot
commented
Sep 15, 2022
Benchmark runs are scheduled for baseline = 06f01ea and contender = f52d8af. f52d8af is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
N/A
Rationale for this change
There is a bug pointed out by @iajoiner#3484 (comment)
We don't see the problem because the only uses of the variant of the macro are all in generics that use
TWhen I remove that variant, you can see the locations
What changes are included in this PR?
Tto$TAre there any user-facing changes?
No