Uh oh!
There was an error while loading. Please reload this page.
feat: Union types coercion - #3513
Conversation
codecov-commenter
commented
Sep 16, 2022
Codecov Report
@@ Coverage Diff @@## master #3513 +/- ##
==========================================
- Coverage 85.75% 85.74% -0.01%
==========================================
Files 299 299 Lines 55311 55352 +41 ==========================================
+ Hits 47432 47462 +30 - Misses 7879 7890 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
left a comment
There was a problem hiding this comment.
Thanks @gandronchik -- I think this PR is looking really good.
The only thing I think is needed prior to merge is 2 more tests. ❤️ Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
57962b9 to
6e6b766Comparegandronchik
commented
Sep 19, 2022
Hi @alamb. Thank you for review. I added more tests and also fixed few bugs 🙏 |
alamb
left a comment
There was a problem hiding this comment.
This looks great -- thank you @gandronchik . I went over the tests carefully and 👍
ursabot
commented
Sep 19, 2022
Benchmark runs are scheduled for baseline = f30fc4e and contender = 4b1e044. 4b1e044 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Union columns with different types
closes#3467