Skip to content

Fix aggregate type coercion bug - #3707

Closed
andygrove wants to merge 5 commits into
apache:masterfrom
andygrove:fix-aggr-coercion
Closed

Fix aggregate type coercion bug#3707
andygrove wants to merge 5 commits into
apache:masterfrom
andygrove:fix-aggr-coercion

Conversation

@andygrove

@andygroveandygrove commented Oct 4, 2022

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes#3704

Rationale for this change

Fixes a recent regression - see issue for details

What changes are included in this PR?

Use canonical expr name

Are there any user-facing changes?

No

@github-actionsgithub-actionsBot added core Core DataFusion crate optimizer Optimizer rules labels Oct 4, 2022
Comment threaddatafusion/optimizer/src/type_coercion.rs Outdated
@andygrove
andygrove requested a review from alambOctober 4, 2022 18:12
Comment threaddatafusion/optimizer/src/type_coercion.rs Outdated
@andygroveandygrove changed the title WIP: Fix aggregate type coercion bugFix aggregate type coercion bugOct 4, 2022
@andygrove
andygrove marked this pull request as ready for review October 4, 2022 21:14
@andygrove

Copy link
Copy Markdown
MemberAuthor

@alamb Could you take another look at this? I know you are also working on a fix in #3710 so would be good to swap notes

@andygrove

Copy link
Copy Markdown
MemberAuthor

Closing in favor of #3710

@andygrove
andygrove deleted the fix-aggr-coercion branch January 27, 2023 18:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion crateoptimizerOptimizer rules

Projects

None yet

2 participants

@andygrove@alamb