You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some fairly simple expressions that should be simplified but yet are not because additional simplifications are unlocked by the constant propagator.
For example
(i * 0) > 5
is only simplified to
0 > 5
Because the flow is
constant evaluator runs on (i * 0) > 5 which can not do anything,
simplfy runs on (i * 0) > 5 and rewrites to 0 > 5
Now, if the constant evaluator can run again it will result in false which is great. However, it is not run again and thus there is the issue.
I hit the same basic embarrassment while making the example in re #1160
The challenges with a fully general solution to this issue are described #1160. However, we have had good luck in IOx simply running the simplification / constant prop twice
Benchmark runs are scheduled for baseline = 7179c54 and contender = 37fe938. 37fe938 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #3741Which issue does this PR close?
re #3740
re #1160
Rationale for this change
There are some fairly simple expressions that should be simplified but yet are not because additional simplifications are unlocked by the constant propagator.
For example
is only simplified to
Because the flow is
(i * 0) > 5which can not do anything,(i * 0) > 5and rewrites to0 > 5Now, if the constant evaluator can run again it will result in
falsewhich is great. However, it is not run again and thus there is the issue.I hit the same basic embarrassment while making the example in re #1160
The challenges with a fully general solution to this issue are described #1160. However, we have had good luck in IOx simply running the simplification / constant prop twice
What changes are included in this PR?
Are there any user-facing changes?
Better constant propagation