Skip to content

include test data and add aggregation tests in integration test - #425

Merged
alamb merged 2 commits into
apache:masterfrom
jimexist:load-more-data-integration-test
May 31, 2021
Merged

include test data and add aggregation tests in integration test#425
alamb merged 2 commits into
apache:masterfrom
jimexist:load-more-data-integration-test

Conversation

@jimexist

@jimexistjimexist commented May 25, 2021

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes#428

Rationale for this change

we'd like to include the test data into psql so that we can test more realistically

What changes are included in this PR?

  • add create table and load csv statement in integration run

Are there any user-facing changes?

@codecov-commenter

codecov-commenter commented May 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #425 (6028904) into master (321fda4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #425 +/- ##
==========================================
- Coverage 75.16% 75.16% -0.01% 
==========================================
Files 150 150 Lines 25144 25145 +1 ==========================================
Hits 18899 18899 - Misses 6245 6246 +1 
Impacted FilesCoverage Δ
datafusion-cli/src/main.rs0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321fda4...6028904. Read the comment docs.

@jimexist
jimexistforce-pushed the load-more-data-integration-test branch 2 times, most recently from 6857908 to f89b706CompareMay 26, 2021 03:03
@jimexist
jimexist marked this pull request as ready for review May 26, 2021 06:41
@jimexistjimexist changed the title include test data in integration testinclude test data and add aggregation tests in integration testMay 26, 2021
@jimexist
jimexistforce-pushed the load-more-data-integration-test branch from ca782d8 to 35c5898CompareMay 26, 2021 07:36
@alamb

Copy link
Copy Markdown
Contributor

The windows failure is unrelated


error: could not copy file from 'C:\Users\runneradmin\.cargo\bin\rustup-init.exe' to 'C:\Users\runneradmin\.cargo\bin\rustup.exe': The process cannot access the file because it is being used by another process. (os error 32)
ResourceUnavailable: D:\a\_temp\25f719e4-aedd-4bf5-b3e9-d027995ab838.ps1:3
Line |
3 | rustup default stable
| ~~~~~~~~~~~~~~~~~~~~~
| Program 'rustup.exe' failed to run: The specified executable is not a valid application for this OS
| platform.At D:\a\_temp\25f719e4-aedd-4bf5-b3e9-d027995ab838.ps1:3 char:1 + rustup default stable +

@alamb

Copy link
Copy Markdown
Contributor

Thanks @jimexist -- this looks nice

@jimexist
jimexistforce-pushed the load-more-data-integration-test branch from 35c5898 to 844e9fdCompareMay 30, 2021 17:05
@alamb
alamb merged commit 80abb09 into apache:masterMay 31, 2021
@jimexist
jimexist deleted the load-more-data-integration-test branch May 31, 2021 14:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enrich integration test to include aggregate csv data

4 participants

@jimexist@codecov-commenter@alamb@houqp