Skip to content

Teach optimizer that CoalesceBatchesExec does not destroy output order - #4332

Merged
alamb merged 1 commit into
apache:masterfrom
alamb:alamb/coalsce_is_sorted
Nov 28, 2022
Merged

Teach optimizer that CoalesceBatchesExec does not destroy output order#4332
alamb merged 1 commit into
apache:masterfrom
alamb:alamb/coalsce_is_sorted

Conversation

@alamb

@alambalamb commented Nov 22, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes#4331

Rationale for this change

See #4331

What changes are included in this PR?

Teach optimizer that CoalesceBatchesExec does not destroy output order

Are these changes tested?

Yes

Are there any user-facing changes?

BasicEnforcement will not add unecessary SortExecs

@github-actionsgithub-actionsBot added the core Core DataFusion crate label Nov 22, 2022
@alamb

alamb commented Nov 23, 2022

Copy link
Copy Markdown
ContributorAuthor

i just need to figure out how to write a test for this PR and it will be ready

@mingmwang

mingmwang commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

I think you can construct a UT to test and verify a sorted input stream is still keep sorted after CoalesceBatchesExec

@alamb
alambforce-pushed the alamb/coalsce_is_sorted branch from a7f5fb6 to 137fb2aCompareNovember 28, 2022 14:51
alamb
alamb commented Nov 28, 2022
View reviewed changes
Comment threaddatafusion/core/src/physical_optimizer/enforcement.rs

// The optimizer should not add an additional SortExec as the
// data is already sorted
let expected = &[

@alambalambNov 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the test (that mimics my usecase in IOx) -- without the changes in this PR this test fails (as there is a SortExec present)

@alamb
alamb marked this pull request as ready for review November 28, 2022 14:52
@alamb
alamb merged commit a31b44e into apache:masterNov 28, 2022
@ursabot

ursabot commented Nov 28, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = dafd957 and contender = a31b44e. a31b44e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
alamb deleted the alamb/coalsce_is_sorted branch November 28, 2022 19:51
@mustafasrepomustafasrepo mentioned this pull request Dec 1, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygroveandygroveandygrove approved these changes

Assignees

No one assigned

Labels

coreCore DataFusion crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CoalesceBatchesExec reports no ordering

4 participants

@alamb@mingmwang@ursabot@andygrove