Uh oh!
There was an error while loading. Please reload this page.
Make SchemaProvider::table async - #4607
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| /// Retrieves a specific table from the schema by name, provided it exists. | ||
| fn table(&self, name: &str) -> Option<Arc<dyn TableProvider>>; | ||
| async fn table(&self, name: &str) -> Option<Arc<dyn TableProvider>>; |
There was a problem hiding this comment.
And this is the change to support async catalogs
tustvold
commented
Dec 15, 2022
This is temporarily on hold pending the work I am doing on cleaning up the config, see #4617. I will come back to this once that is complete |
tustvold
commented
Jan 3, 2023
I think this is now ready for review, it would be amazing if this could make this weeks release as this has been a frequently requested feature |
| /// Creates a [`LogicalPlan`] from the provided SQL string | ||
| /// | ||
| /// See [`SessionContext::sql`] for a higher-level interface that also handles DDL | ||
| pub async fn create_logical_plan(&self, sql: &str) -> Result<LogicalPlan> { |
There was a problem hiding this comment.
This is specifically broken out into a separate function so that database's that want to not handle DDL, such as IOx, don't have to re-implement this functionality. FYI @alamb
| } | ||
| // Always include information_schema if available | ||
| if self.config.information_schema() { |
There was a problem hiding this comment.
#4606 means there isn't a cost to doing this
alamb
commented
Jan 3, 2023
Will review this tomorrow. Note the CI is failing |
| ControlFlow::Continue(()) | ||
| } | ||
| fn pre_visit_statement( |
There was a problem hiding this comment.
This is a bit gross, but I hope to split apart the query planning from the other types of query, that will clean this up.
This change makes sense to me. It's a good solution to only change one interface, I like it! The only thing left is asynchronous register things, but on the one hand it's less important than getting and deregistering, and another hand there are still ways to workaround (like update-on-getting). So I'm +1 for providing this change as-is. Thanks for making this @tustvold 🥳 |
tustvold
commented
Jan 4, 2023
We can easily add this as a follow up, as the catalog is largely a detail of SessionContext, I don't imagine it causing any major issues. |
alamb
left a comment
There was a problem hiding this comment.
Other than putting back unsupported_sql_returns_error I think this PR looks good to me. My other comments are just minor suggestions
Uh oh!
There was an error while loading. Please reload this page.
| /// Retrieves a specific table from the schema by name, provided it exists. | ||
| fn table(&self, name: &str) -> Option<Arc<dyn TableProvider>>; | ||
| async fn table(&self, name: &str) -> Option<Arc<dyn TableProvider>>; |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ursabot
commented
Jan 5, 2023
Benchmark runs are scheduled for baseline = 087ac09 and contender = fad77a4. fad77a4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes#3777.
Rationale for this change
What changes are included in this PR?
Makes
SchemaProvider::tableasync.Are these changes tested?
Are there any user-facing changes?