Uh oh!
There was an error while loading. Please reload this page.
fix: run logical optimizer rules for TableScan expressions - #4614
Conversation
| \n Aggregate: groupBy=[[]], aggr=[[AVG(customer.c_acctbal)]]\ | ||
| \n Filter: customer.c_acctbal > Decimal128(Some(0),15,2) AND substr(customer.c_phone, Int64(1), Int64(2)) IN ([Utf8(\"13\"), Utf8(\"31\"), Utf8(\"23\"), Utf8(\"29\"), Utf8(\"30\"), Utf8(\"18\"), Utf8(\"17\")])\ | ||
| \n TableScan: customer projection=[c_phone, c_acctbal], partial_filters=[CAST(customer.c_acctbal AS Decimal128(30, 15)) > Decimal128(Some(0),30,15), substr(customer.c_phone, Int64(1), Int64(2)) IN ([Utf8(\"13\"), Utf8(\"31\"), Utf8(\"23\"), Utf8(\"29\"), Utf8(\"30\"), Utf8(\"18\"), Utf8(\"17\")]), customer.c_acctbal > Decimal128(Some(0),15,2)]"; | ||
| \n TableScan: customer projection=[c_phone, c_acctbal], partial_filters=[customer.c_acctbal > Decimal128(Some(0),15,2) AS customer.c_acctbal > Decimal128(Some(0),30,15), substr(customer.c_phone, Int64(1), Int64(2)) IN ([Utf8(\"13\"), Utf8(\"31\"), Utf8(\"23\"), Utf8(\"29\"), Utf8(\"30\"), Utf8(\"18\"), Utf8(\"17\")]), customer.c_acctbal > Decimal128(Some(0),15,2)]"; |
alamb
commented
Dec 14, 2022
I am merging this in as I don't think it is controversial -- instead it is a fix for an oversight |
ursabot
commented
Dec 14, 2022
Benchmark runs are scheduled for baseline = 508ba80 and contender = 40e6a67. 40e6a67 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Doesn't close any, but is related to #4370.
Rationale for this change
While working on #4370 I've discovered that we don't optimize expressions within
TableScannodes.What changes are included in this PR?
Include
TableScanexpressions within the logical optimization.Are these changes tested?
See plan change in
tpch_q22_correlated.Are there any user-facing changes?
Better optimized plans.