Skip to content

git-ignore datafusion/proto/src/generated/datafusion.rs - #4640

Closed
crepererum wants to merge 1 commit into
apache:masterfrom
crepererum:crepererum/fix_gitignore
Closed

git-ignore datafusion/proto/src/generated/datafusion.rs#4640
crepererum wants to merge 1 commit into
apache:masterfrom
crepererum:crepererum/fix_gitignore

Conversation

@crepererum

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

-

Rationale for this change

I was close to accidentally adding this file to my PRs so many times by now, let's just git-ignore it.

What changes are included in this PR?

New git-ignore rule.

Are these changes tested?

-

Are there any user-facing changes?

-

@tustvold

Copy link
Copy Markdown
Contributor

This is intentionally checked in https://github.com/apache/arrow-datafusion/blob/master/datafusion/proto/proto/datafusion.proto as part of the story around not needing users to have protoc installed? It is gross, but see #3950 for more context

If you're seeing a diff this would imply something is off with the version pins somewhere?

@crepererum

Copy link
Copy Markdown
ContributorAuthor

I'm not talking about the proto file but the generated .rs file. The latter one is NOT checked in at the moment (although I can change this PR to do so).

@tustvold

Copy link
Copy Markdown
Contributor

Oh... I'm curious what is generating that, is it some artifact from before #3950 perhaps? I can't seem to generate such a file locally...

@jackwenerjackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also meet this😂

@crepererum

Copy link
Copy Markdown
ContributorAuthor

I cannot reproduce this on current master anymore. Maybe it's a left-over.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@crepererum@tustvold@jackwener