Skip to content

fix cargo clippy warning - #4652

Merged
Dandandan merged 1 commit into
apache:masterfrom
jackwener:clippy
Dec 16, 2022
Merged

fix cargo clippy warning#4652
Dandandan merged 1 commit into
apache:masterfrom
jackwener:clippy

Conversation

@jackwener

@jackwenerjackwener commented Dec 16, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes#4653#4654 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added the logical-expr Logical plan and expressions label Dec 16, 2022
@HaoYang670

HaoYang670 commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

This will close #4653

@jackwenerjackwener mentioned this pull request Dec 16, 2022
Merged
@HaoYang670HaoYang670 mentioned this pull request Dec 16, 2022
Closed
@github-actionsgithub-actionsBot added core Core DataFusion crate optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner labels Dec 16, 2022
HaoYang670
HaoYang670 approved these changes Dec 16, 2022
View reviewed changes

@HaoYang670HaoYang670 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HaoYang670HaoYang670 linked an issue Dec 16, 2022 that may be closed by this pull request
Wrongly use the function clamp#4654
Closed
@mingmwang

mingmwang commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

👍

@mingmwang

mingmwang commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Waiting for this PR to get merged.

@Dandandan
Dandandan merged commit 8504cb2 into apache:masterDec 16, 2022
@jackwener
jackwener deleted the clippy branch December 16, 2022 10:00
@ursabot

ursabot commented Dec 16, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 9667887 and contender = 8504cb2. 8504cb2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb

alamb commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Thank you @jackwener

@alambalamb mentioned this pull request Dec 16, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HaoYang670HaoYang670HaoYang670 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

coreCore DataFusion cratelogical-exprLogical plan and expressionsoptimizerOptimizer rulesphysical-exprChanges to the physical-expr cratessqlSQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrongly use the function clamp Fix the clippy errors

6 participants

@jackwener@HaoYang670@mingmwang@ursabot@alamb@Dandandan