Skip to content

remove SubqueryFilterToJoin - #4731

Merged
alamb merged 2 commits into
apache:masterfrom
jackwener:delete
Dec 28, 2022
Merged

remove SubqueryFilterToJoin#4731
alamb merged 2 commits into
apache:masterfrom
jackwener:delete

Conversation

@jackwener

@jackwenerjackwener commented Dec 26, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A

Rationale for this change

From comment of @liukun4515#4725 (comment)

SubqueryFilterToJoin is useless, because DecorrelateWhereIn exist

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

None

@github-actionsgithub-actionsBot added the optimizer Optimizer rules label Dec 26, 2022
@jackwenerjackwener mentioned this pull request Dec 26, 2022
Closed
alamb
alamb approved these changes Dec 26, 2022
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jackwener -- this is a nice cleanup!

Comment threaddatafusion/optimizer/src/decorrelate_where_in.rs
.build()?;

let expected = "Projection: test.b [b:UInt32]\
\n LeftSemi Join: test.b = __sq_2.c [a:UInt32, b:UInt32, c:UInt32]\

@alambalambDec 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@liukun4515

liukun4515 commented Dec 27, 2022

Copy link
Copy Markdown
Contributor

cc @avantgardnerio@korowa the author of these two rules

@alamb

alamb commented Dec 27, 2022

Copy link
Copy Markdown
Contributor

I plan to merge this tomorrow unless anyone else would like time to comment

@ygf11ygf11 mentioned this pull request Dec 28, 2022
Closed
@alamb
alamb merged commit fc8fb06 into apache:masterDec 28, 2022
@alamb

alamb commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

Thanks @jackwener and @liukun4515

@ursabot

ursabot commented Dec 28, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 326117c and contender = fc8fb06. fc8fb06 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener
jackwener deleted the delete branch December 28, 2022 23:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alambalambalamb approved these changes
@liukun4515liukun4515liukun4515 approved these changes

Assignees

No one assigned

Labels

optimizerOptimizer rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackwener@liukun4515@alamb@ursabot