Skip to content

Deprecate SessionContext physical plan methods (#4617) - #4751

Merged
tustvold merged 1 commit into
apache:masterfrom
tustvold:deprecate-session-context-physical-plan
Dec 28, 2022
Merged

Deprecate SessionContext physical plan methods (#4617)#4751
tustvold merged 1 commit into
apache:masterfrom
tustvold:deprecate-session-context-physical-plan

Conversation

@tustvold

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #4617

Follow on to #4679

Rationale for this change

These methods are very easy to accidentally misuse, and end up planning or optimizing against a different state than used for previous phases. Deprecating them will hopefully encourage correct usage of these APIs

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@tustvoldtustvold added the api change Changes the API exposed to users of the crate label Dec 27, 2022
@github-actionsgithub-actionsBot added the core Core DataFusion crate label Dec 27, 2022
@tustvold
tustvoldforce-pushed the deprecate-session-context-physical-plan branch from 26f97d3 to 985ff14CompareDecember 27, 2022 21:43
@tustvold
tustvold requested a review from alambDecember 28, 2022 20:23

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@tustvold
tustvold merged commit c9350d1 into apache:masterDec 28, 2022
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 40bf559 and contender = c9350d1. c9350d1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api changeChanges the API exposed to users of the cratecoreCore DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tustvold@ursabot@alamb