Uh oh!
There was an error while loading. Please reload this page.
[Ballista] Remove hard coded ballista versions in scripts - #49
Merged
Conversation
codecov-commenter
commented
Apr 24, 2021
Codecov Report
@@ Coverage Diff @@## master #49 +/- ##
=======================================
Coverage 76.24% 76.24% =======================================
Files 134 134 Lines 23051 23051 =======================================
Hits 17576 17576 Misses 5475 5475
Continue to review full report at Codecov.
|
andygrove
approved these changes
Apr 24, 2021
andygrove
left a comment
Member
There was a problem hiding this comment.
LGTM. I tested locally and integration tests passed.
Dandandan
approved these changes
Apr 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#32 .
Rationale for this change
Versions are hardcoded in too many places.
What changes are included in this PR?
Greps version from
ballista/rust/core/Cargo.tomland exports it, so other scripts can use it.Are there any user-facing changes?
N/A