Uh oh!
There was an error while loading. Please reload this page.
Refactor window aggregation, simplify batch processing logic - #516
Merged
Conversation
jimexist
marked this pull request as draft
June 6, 2021 07:06
jimexist
marked this pull request as ready for review
June 6, 2021 07:48
jimexistforce-pushed
the
refactor-window
branch
2 times, most recently
from
June 7, 2021 11:59
6a89e50 to
30548d6Comparealamb
approved these changes
Jun 7, 2021
alamb
left a comment
Contributor
There was a problem hiding this comment.
looks like a nice improvement to me
HairstonE pushed a commit
to HairstonE/datafusion
that referenced
this pull request
Oct 7, 2025
Bumps [pyo3-build-config](https://github.com/pyo3/pyo3) from 0.19.2 to 0.20.0. - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md) - [Commits](PyO3/pyo3@v0.19.2...v0.20.0) --- updated-dependencies: - dependency-name: pyo3-build-config dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related #299 and #360
based on #515
Rationale for this change
simplify batch processing logic for window functions, so that instead of batch by batch we'll in next pull request switch to partition by partition process, which requires all input batches to be gathered together first
What changes are included in this PR?
Are there any user-facing changes?