Skip to content

Fix 517 - move window_frames module to logical_plan - #518

Merged
alamb merged 1 commit into
apache:masterfrom
jimexist:fix-517
Jun 7, 2021
Merged

Fix 517 - move window_frames module to logical_plan#518
alamb merged 1 commit into
apache:masterfrom
jimexist:fix-517

Conversation

@jimexist

@jimexistjimexist commented Jun 6, 2021

Copy link
Copy Markdown
Member

Which issue does this PR close?

Based on #506
Closes#517.

Rationale for this change

What changes are included in this PR?

move window_frames module to logical_plan

Are there any user-facing changes?

@jimexistjimexist changed the title Fix 517Fix 517 - move window_frames module to logical_planJun 6, 2021
@jimexist
jimexistforce-pushed the fix-517 branch 2 times, most recently from bb08f61 to 01d08a7CompareJune 7, 2021 03:20
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #518 (01d08a7) into master (b84789a) will decrease coverage by 0.01%.
The diff coverage is 70.10%.

Impacted file tree graph

@@ Coverage Diff @@## master #518 +/- ##
==========================================
- Coverage 76.09% 76.07% -0.02% 
==========================================
Files 155 156 +1 Lines 26575 26750 +175 ==========================================
+ Hits 20221 20351 +130 - Misses 6354 6399 +45 
Impacted FilesCoverage Δ
...sta/rust/core/src/serde/logical_plan/from_proto.rs35.41% <0.00%> (-0.51%)⬇️
...lista/rust/core/src/serde/logical_plan/to_proto.rs61.64% <0.00%> (-0.77%)⬇️
...ta/rust/core/src/serde/physical_plan/from_proto.rs38.51% <0.00%> (-0.14%)⬇️
datafusion-cli/src/lib.rs0.00% <0.00%> (ø)
datafusion-cli/src/main.rs0.00% <0.00%> (ø)
datafusion/src/optimizer/utils.rs48.05% <0.00%> (-0.18%)⬇️
datafusion/src/physical_plan/planner.rs80.19% <ø> (ø)
datafusion/src/sql/utils.rs66.54% <50.00%> (-0.25%)⬇️
datafusion/src/logical_plan/expr.rs84.56% <81.81%> (-0.05%)⬇️
datafusion/src/logical_plan/window_frames.rs86.60% <86.60%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2b9ef...01d08a7. Read the comment docs.

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @houqp -- thanks @jimexist 👍

@alamb
alamb merged commit 63accf8 into apache:masterJun 7, 2021
@jimexist
jimexist deleted the fix-517 branch June 7, 2021 15:06
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
…che#518)
* chore: Add UnboundColumn to carry datatype for unbound reference
* Update core/src/execution/datafusion/expressions/unbound.rs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move window frame module to be in logical_plan

4 participants

@jimexist@codecov-commenter@alamb@houqp