Skip to content

add error handling and boundary checking for window frames - #530

Merged
alamb merged 1 commit into
apache:masterfrom
jimexist:optimize-window-frames
Jun 10, 2021
Merged

add error handling and boundary checking for window frames#530
alamb merged 1 commit into
apache:masterfrom
jimexist:optimize-window-frames

Conversation

@jimexist

@jimexistjimexist commented Jun 10, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes#529
Closes#528

Rationale for this change

What changes are included in this PR?

  1. add boundary case checking for window frames
  2. remove stale window frame implementations in physical planner (possibly due to rebase error)

Are there any user-facing changes?

@jimexist
jimexistforce-pushed the optimize-window-frames branch from a86818f to 2f60903CompareJune 10, 2021 03:48
@codecov-commenter

codecov-commenter commented Jun 10, 2021

Copy link
Copy Markdown

Codecov Report

Merging #530 (2f60903) into master (d5bca0e) will increase coverage by 0.04%.
The diff coverage is 83.67%.

Impacted file tree graph

@@ Coverage Diff @@## master #530 +/- ##
==========================================
+ Coverage 76.03% 76.07% +0.04% 
==========================================
Files 157 156 -1 Lines 26990 26923 -67 ==========================================
- Hits 20521 20483 -38 + Misses 6469 6440 -29
Impacted FilesCoverage Δ
...sta/rust/core/src/serde/logical_plan/from_proto.rs35.04% <0.00%> (-0.17%)⬇️
datafusion/src/physical_plan/mod.rs78.70% <ø> (ø)
datafusion/src/logical_plan/window_frames.rs87.87% <85.00%> (+1.27%)⬆️
datafusion/src/sql/planner.rs84.85% <100.00%> (+0.23%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bca0e...2f60903. Read the comment docs.

alamb
alamb approved these changes Jun 10, 2021
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jimexist -- thanks

@alamb
alamb merged commit 77775b7 into apache:masterJun 10, 2021
@jimexist
jimexist deleted the optimize-window-frames branch June 10, 2021 15:17
@jimexist

jimexist commented Jun 10, 2021

Copy link
Copy Markdown
MemberAuthor

Looks great @jimexist -- thanks

yeah window functions are hard

@houqphouqp added datafusion enhancement New feature or request labels Jul 30, 2021
HairstonE pushed a commit to HairstonE/datafusion that referenced this pull request Oct 7, 2025
@andygrove
Upgrade to DataFusion 33.0.0-rc1 (apache#530)
e4942b8
* fix issues
* fix TODO
* clippy
* use df 33.0.0-rc1
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alambalambalamb approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

4 participants

@jimexist@codecov-commenter@alamb@houqp