Skip to content

turn on clippy rule for needless borrow - #545

Merged
alamb merged 3 commits into
apache:masterfrom
jimexist:clippy-needless-borrow
Jun 13, 2021
Merged

turn on clippy rule for needless borrow#545
alamb merged 3 commits into
apache:masterfrom
jimexist:clippy-needless-borrow

Conversation

@jimexist

@jimexistjimexist commented Jun 12, 2021

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #545 (f14084a) into master (ad70a1e) will decrease coverage by 0.02%.
The diff coverage is 84.56%.

Impacted file tree graph

@@ Coverage Diff @@## master #545 +/- ##
==========================================
- Coverage 76.13% 76.11% -0.03% 
==========================================
Files 156 156 Lines 27032 27025 -7 ==========================================
- Hits 20582 20571 -11 - Misses 6450 6454 +4 
Impacted FilesCoverage Δ
...lista/rust/core/src/serde/logical_plan/to_proto.rs61.41% <0.00%> (+0.07%)⬆️
ballista/rust/executor/src/flight_service.rs0.00% <ø> (ø)
ballista/rust/scheduler/src/state/mod.rs70.49% <0.00%> (ø)
datafusion/src/physical_plan/expressions/case.rs75.00% <0.00%> (-0.57%)⬇️
...fusion/src/physical_plan/expressions/row_number.rs81.25% <0.00%> (ø)
datafusion/src/physical_plan/repartition.rs84.42% <ø> (-0.06%)⬇️
benchmarks/src/bin/tpch.rs30.84% <12.50%> (ø)
datafusion/src/execution/context.rs92.00% <25.00%> (-0.09%)⬇️
datafusion/src/physical_plan/windows.rs86.46% <33.33%> (ø)
datafusion/src/physical_plan/hash_join.rs84.89% <57.14%> (-0.63%)⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad70a1e...f14084a. Read the comment docs.

@alamb

Copy link
Copy Markdown
Contributor

Thank you @jimexist !

@alamb
alamb merged commit 738f13b into apache:masterJun 13, 2021
@jimexist
jimexist deleted the clippy-needless-borrow branch June 13, 2021 11:26
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
* Add changelog generator script
* minor fixes
* minor fixes
* rat
* rat
* remove example changelog
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jimexist@codecov-commenter@alamb@Dandandan@houqp@andygrove