Skip to content

Support modulus op - #577

Merged
alamb merged 1 commit into
apache:masterfrom
flock-lab:mmod
Jun 22, 2021
Merged

Support modulus op#577
alamb merged 1 commit into
apache:masterfrom
flock-lab:mmod

Conversation

@gangliao

@gangliaogangliao commented Jun 17, 2021

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

apache/arrow-rs#98
#99
apache/arrow-rs#317

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@gangliaogangliao mentioned this pull request Jun 17, 2021
@gangliao

Copy link
Copy Markdown
ContributorAuthor

@alamb Thanks!

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @gangliao

I have triggered CI to start and if it is green I think this one is good to merge

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #577 (29319f0) into master (51e5445) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@ Coverage Diff @@## master #577 +/- ##
==========================================
+ Coverage 76.02% 76.04% +0.02% 
==========================================
Files 156 156 Lines 27063 27071 +8 ==========================================
+ Hits 20575 20587 +12 + Misses 6488 6484 -4 
Impacted FilesCoverage Δ
datafusion/src/physical_plan/expressions/binary.rs90.66% <87.50%> (+1.18%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e5445...29319f0. Read the comment docs.

@alamb
alamb merged commit d55a105 into apache:masterJun 22, 2021
@houqphouqp added datafusion enhancement New feature or request labels Jul 30, 2021
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
* fix: Improve error "BroadcastExchange is not supported"
* Update queries list
* Add more explanations. Fix plan stability regression.
* Make extended explain more user friendly (provide a tree view of plan with info)
* fix ci
* address review comment
* spotless
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@gangliao@codecov-commenter@alamb@houqp