Skip to content

User guide lists window functions - #6402

Merged
alamb merged 5 commits into
apache:mainfrom
toppyy:document_window_functions
May 29, 2023
Merged

User guide lists window functions#6402
alamb merged 5 commits into
apache:mainfrom
toppyy:document_window_functions

Conversation

@toppyy

@toppyytoppyy commented May 21, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes#6338.

Rationale for this change

List window functions in the user guide

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

comphead
comphead reviewed May 21, 2023
View reviewed changes
Comment threaddocs/source/user-guide/sql/window_functions.md Outdated
@alambalamb mentioned this pull request May 22, 2023
Closed
alamb
alamb reviewed May 22, 2023
View reviewed changes
Comment threaddocs/source/user-guide/sql/window_functions.md Outdated
Comment threaddocs/source/user-guide/sql/window_functions.md Outdated

# Window Functions

Window functions calculate a value for a set of rows within a result set.

@alambalambMay 22, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably copy some/all of the description from the postgres docs rather than having to reinvent it: https://www.postgresql.org/docs/current/tutorial-window.html

@toppyytoppyyMay 24, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I stitched together a description of window functions from the postgres docs and added a sub-section describing the syntax.

(EDIT: Just noticed that named windows are now supported, I'll add those the syntax description next) Named window functions are described also.

comphead
comphead reviewed May 24, 2023
View reviewed changes
Comment threaddocs/source/user-guide/sql/window_functions.md
@toppyy
toppyy marked this pull request as ready for review May 28, 2023 06:44
@alambalamb added documentation Improvements or additions to documentation datafusion labels May 29, 2023
alamb
alamb approved these changes May 29, 2023
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thank you so much @toppyy

Comment threaddocs/source/user-guide/sql/window_functions.md
```sql
SELECT sum(salary) OVER w, avg(salary) OVER w
FROM empsalary
WINDOW w AS (PARTITION BY depname ORDER BY salary DESC);

@alambalambMay 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature (named window functions) was added just a few days ago by @berkaysynnada#6419 🎉

@alamb
alamb merged commit c768c9b into apache:mainMay 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compheadcompheadcomphead left review comments
@alambalambalamb approved these changes

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document Window functions

3 participants

@toppyy@alamb@comphead