Skip to content

Move ExecutionPlan and related structures into datafusion-execution crate - #6514

Closed
alamb wants to merge 6 commits into
apache:mainfrom
alamb:alamb/move_traits
Closed

Move ExecutionPlan and related structures into datafusion-execution crate#6514
alamb wants to merge 6 commits into
apache:mainfrom
alamb:alamb/move_traits

Conversation

@alamb

@alambalamb commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #1754

Rationale for this change

I am working on extracting datafusion/core/src/physical_plan and datafusion/core/src/physical_optimizer and datafusion/core/src/datasource to their own crates.

However, they all depend on ExecutionPlan

What changes are included in this PR?

Hoist ExecutionPlan and related types / structs into datafusion_execution

I envision the dependency tree looking like:

datafusion-core -----------> datafusion_datasource ---------------------> datafusion_execution
\------datafusion_physical_optimizer --> datafusion_physical_plan --/

Are these changes tested?

existing tests

Are there any user-facing changes?

I don't think so -- I left pub use's around to avoid breaking API changes

@github-actionsgithub-actionsBot added core Core DataFusion crate physical-expr Changes to the physical-expr crates labels Jun 1, 2023
@alamb
alamb marked this pull request as ready for review June 1, 2023 15:29
@alamb

alamb commented Jun 1, 2023

Copy link
Copy Markdown
ContributorAuthor

could also be convinced this is not a good idea (leaving all the code in datafusion_physical_plan) if possible

@alamb

alamb commented Jun 2, 2023

Copy link
Copy Markdown
ContributorAuthor

I am still thinking about if this is a good idea -- there is a certain benefit to keeping ExecutionPlan in the physical_plan module which has most of the structures implementing ExecutionPlan

@alamb

alamb commented Jun 2, 2023

Copy link
Copy Markdown
ContributorAuthor

I think it will be very hard to decouple datasource from physical_plan and thus I am going to postpone this PR

Instead I will proceed via #6516

@alambalamb closed this Jun 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratephysical-exprChanges to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb@tustvold