Skip to content

Show physical plan with metrics in benchmark - #662

Merged
Dandandan merged 1 commit into
apache:masterfrom
andygrove:display-metrics-in-benchmark
Jul 4, 2021
Merged

Show physical plan with metrics in benchmark#662
Dandandan merged 1 commit into
apache:masterfrom
andygrove:display-metrics-in-benchmark

Conversation

@andygrove

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes#396 .

Rationale for this change

Metrics are really useful when performance tuning and debugging issues.

What changes are included in this PR?

Benchmark shows the physical plan with metrics when --debug parameter is used.

Are there any user-facing changes?

Benchmark output improved.

@Dandandan
Dandandan merged commit a5b3a81 into apache:masterJul 4, 2021

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alambalamb mentioned this pull request Jul 26, 2021
@houqphouqp added the enhancement New feature or request label Jul 31, 2021
@alambalamb mentioned this pull request Aug 11, 2021
@andygrove
andygrove deleted the display-metrics-in-benchmark branch February 6, 2022 17:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataFusion benchmarks should show executed plan with metrics after query completes

4 participants

@andygrove@Dandandan@alamb@houqp