Skip to content

Minor: Add array / array sqllogic tests for array_contains - #6771

Merged
alamb merged 3 commits into
apache:mainfrom
alamb:alamb/array_contains_tests
Jun 28, 2023
Merged

Minor: Add array / array sqllogic tests for array_contains#6771
alamb merged 3 commits into
apache:mainfrom
alamb:alamb/array_contains_tests

Conversation

@alamb

@alambalamb commented Jun 26, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Related to #6709

Rationale for this change

While reviewing #6618 I felt there was a gap in coverage:

What changes are included in this PR?

tests for array functions on array functions

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Jun 26, 2023
@alambalamb mentioned this pull request Jun 26, 2023
Merged
@izveigor

izveigor commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

Is there any idea to do something similar with math, string, time functions? 🤔
Sources:
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/math.slt
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/scalar.slt
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/strings.slt

@alamb

alamb commented Jun 27, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Is there any idea to do something similar with math, string, time functions? 🤔

We should for sure -- I wonder if we can leverage existing .slt files (from sqllite, for example). It would be a good thing / gap to track with tickets

@alamb
alambforce-pushed the alamb/array_contains_tests branch from 6be5869 to dd40420CompareJune 27, 2023 18:40
@github-actionsgithub-actionsBot removed logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates labels Jun 27, 2023
@alamb
alamb marked this pull request as ready for review June 27, 2023 18:41
@alambalamb changed the title Add array / array sqllogic tests for array_containsMinor: Add array / array sqllogic tests for array_containsJun 27, 2023
izveigor
izveigor reviewed Jun 28, 2023
View reviewed changes
Comment threaddatafusion/core/tests/sqllogictests/test_files/array.slt

# array_contains array

statement ok

@izveigorizveigorJun 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to test nested arrays even more.

@alambalambJun 28, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in eb6e88f

izveigor
izveigor reviewed Jun 28, 2023
View reviewed changes
Comment threaddatafusion/core/tests/sqllogictests/test_files/array.slt
@izveigorizveigor mentioned this pull request Jun 28, 2023
Merged
@alamb
alamb merged commit 6c8df1a into apache:mainJun 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@izveigorizveigorizveigor left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

coreCore DataFusion cratesqllogictestSQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb@izveigor