Uh oh!
There was an error while loading. Please reload this page.
minor: with_inputs() can use original schema. - #6824
Closed
jackwener wants to merge 2 commits into
Closed
Conversation
jackwener
commented
Jul 2, 2023
Comment on lines
-1242
to
-1245
| let input_schema = DFSchema::new_with_metadata( | ||
| exprlist_to_fields(&projected_expr, &plan)?, | ||
| plan.schema().metadata().clone(), | ||
| )?; |
MemberAuthor
There was a problem hiding this comment.
it already was contained by try_new_with_schema, so we can use try_new_with_schema directly
| }) | ||
| .collect::<Vec<_>>(); | ||
| let projection = | ||
| logical_plan::Projection::try_new_with_schema( |
MemberAuthor
There was a problem hiding this comment.
here we shouldn't use join_schema, because join_schema may contain some column which don't exist in project schema
jackwener
commented
Jul 3, 2023
MemberAuthor
`` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
following #6820
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?