Uh oh!
There was an error while loading. Please reload this page.
Column support for array concat - #6879
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| # [[5, 6], [7, 8], [5, 6], [7, 8]] [7.7, 8.8, 9.9, 7.7, 8.8, 9.9] [d, , l, o, r, d, , l, o, r] | ||
| # [[7, ], [9, 10], [7, ], [9, 10]] [10.1, , 12.2, 10.1, , 12.2] [s, i, t, s, i, t] | ||
| # NULL [13.3, 14.4, 15.5, 13.3, 14.4, 15.5] [a, m, e, t, a, m, e, t] | ||
| # [[11, 12], [13, 14], [11, 12], [13, 14]] NULL [,, ,] |
There was a problem hiding this comment.
Not sure do we need an additional "" for commas.
jayzhan211
commented
Jul 11, 2023
Not all kinds of tests are passed but I think they can be solved in another PR. I think we can review this PR first. |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
commented
Jul 12, 2023
| let builder = mutable.into_builder(); | ||
| let list = builder |
There was a problem hiding this comment.
Maybe it's better to consider the method try_new? (https://docs.rs/arrow/latest/arrow/array/struct.GenericListArray.html#method.try_new) 🤔
There was a problem hiding this comment.
I prefer to construct with ListArray::new instead of MutableArrayData too, but I fail on this.
izveigor
left a comment
There was a problem hiding this comment.
Thank you, @jayzhan211! LGTM!
alamb
left a comment
There was a problem hiding this comment.
Thank you @izveigor and @jayzhan211
Which issue does this PR close?
Ref #6804
Rationale for this change
Array concat with columns! Behavior is similar to Postgres.
Concat Operator
a || bis not included in this PR!What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?