Uh oh!
There was an error while loading. Please reload this page.
chore: break earlier in macro contains! - #6989
Merged
Merged
Conversation
containscontains!alamb
approved these changes
Jul 17, 2023
alamb
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me. THank you @Weijun-H
It possible I think it would be great if @jayzhan211 or @izveigor could give it a look as well
izveigor
commented
Jul 17, 2023
Contributor
@alamb I don't think this feature makes sense now since I and @jayzhan211 have decided to rewrite |
jayzhan211
commented
Jul 17, 2023
Contributor
Actually, I did similar improvements in my |
izveigor
approved these changes
Jul 17, 2023
izveigor
left a comment
Contributor
There was a problem hiding this comment.
Agree with @jayzhan211. LGTM!
alamb
commented
Jul 17, 2023
Contributor
Thanks everyone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?