Uh oh!
There was an error while loading. Please reload this page.
Minor: Refactor group by state machine - #7025
Closed
alamb wants to merge 2 commits into
Closed
Conversation
alamb
commented
Jul 19, 2023
| } | ||
| /// Extracts a successful Ok(_) or returns Poll::Ready(Some(Err(e))) with errors | ||
| macro_rules! extract_ok { |
ContributorAuthor
There was a problem hiding this comment.
This macro was removed, but I think breaking the main state loop change into two different functions makes is slightly harder to follow the logic.
Thus I am inclined not to pursue this PR anymore
tustvold
approved these changes
Jul 19, 2023
tustvold
left a comment
Contributor
There was a problem hiding this comment.
I happen to like that this splits out the transition functions from the state machine proper, but I don't feel strongly
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
alamb
marked this pull request as ready for review
July 19, 2023 21:00
alamb
commented
Jul 22, 2023
ContributorAuthor
I think I am inclined to leave this code alone for now as it has already undergone a bunch of churn and this is just stylistic and I want to move on to other things. If anyone else feels differently, please feel free to open a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #6932
Rationale for this change
I was a little unhappy about the
extract_ok!macro and @tustvoldoffered a suggestion on how to remove it: https://github.com/apache/arrow-datafusion/pull/6932/files#r1267309181
This PR is what I came up with . I am not really sure it is better but wanted to put it up in case others had an opinion
What changes are included in this PR?
Pull out the state machine transition logic in group by into some new functions and remove the
extract_ok!macroAre these changes tested?
Are there any user-facing changes?