Skip to content

avoid iterator materialization in column index lookup - #703

Merged
alamb merged 1 commit into
apache:masterfrom
houqp:qp_iter
Jul 12, 2021
Merged

avoid iterator materialization in column index lookup#703
alamb merged 1 commit into
apache:masterfrom
houqp:qp_iter

Conversation

@houqp

Copy link
Copy Markdown
Member

Rationale for this change

Follow up for #605.

What changes are included in this PR?

Avoid unnecessary iterator materialization based on the suggestion from #605 (comment).

Are there any user-facing changes?

no

@jorgecarleitaojorgecarleitao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @houqp 👍

@alamb
alamb merged commit 0a05acf into apache:masterJul 12, 2021
@houqp
houqp deleted the qp_iter branch July 12, 2021 17:27
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
HairstonE pushed a commit to HairstonE/datafusion that referenced this pull request Oct 7, 2025
* fix pushdown for pyarrow filter IsNull
The conversion was incorrectly passing in the expression itself as the `nan_as_null` argument. This caused the pushdown to silently fail.
* expand the Expr::Literal's that can be used in PyArrowFilterExpression
Closesapache#703
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@houqp@alamb@jorgecarleitao