Uh oh!
There was an error while loading. Please reload this page.
Minor: Improve doc comments to datafusion-sql - #7318
Merged
Conversation
alamb
marked this pull request as ready for review
August 17, 2023 12:55
izveigor
approved these changes
Aug 17, 2023
viirya
reviewed
Aug 17, 2023
Uh oh!
There was an error while loading. Please reload this page.
viirya
approved these changes
Aug 17, 2023
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Weijun-H
approved these changes
Aug 18, 2023
alamb
commented
Aug 18, 2023
ContributorAuthor
Thanks everyone for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
@devinjdangelo noted that the distinction between the DataFusion SQL parser and sqlparser was somewhat unclear: #7291 (comment)
What changes are included in this PR?
Update doc comments in the
datafusion-sqlmodule to try and make the rationale / distinction clearerAre these changes tested?
N/A
Are there any user-facing changes?
Just documentation