Uh oh!
There was an error while loading. Please reload this page.
Minor: improve docstrings on SessionState - #7654
Merged
Merged
Conversation
viirya
reviewed
Sep 25, 2023
Uh oh!
There was an error while loading. Please reload this page.
viirya
approved these changes
Sep 25, 2023
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
alamb
commented
Sep 25, 2023
ContributorAuthor
Thank you @viirya |
Ted-Jiang pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
* Minor: improve docstrings on `SessionState` * Update datafusion/core/src/execution/context.rs Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com> --------- Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to a discussion with @Ted-Jiang on https://github.com/apache/arrow-datafusion/pull/7620/files#r1334962930
Rationale for this change
There is a reason there is no
Defaultimpl forSessionStatebut that reason is not explicitly documented anywhere. Let's document it.What changes are included in this PR?
Add docstrings to
SessionStateAre these changes tested?
Are there any user-facing changes?