Skip to content

[MINOR]: Resolve linter errors in the main - #7753

Merged
mustafasrepo merged 1 commit into
apache:mainfrom
synnada-ai:bug_fix/linter_update
Oct 6, 2023
Merged

[MINOR]: Resolve linter errors in the main#7753
mustafasrepo merged 1 commit into
apache:mainfrom
synnada-ai:bug_fix/linter_update

Conversation

@mustafasrepo

@mustafasrepomustafasrepo commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

With new version of RUST 1.73.0, some of the existing code doesn't pass from clippy. This PR resolves these linter errors.

What changes are included in this PR?

Are these changes tested?

Existing tests should work

Are there any user-facing changes?

@github-actionsgithub-actionsBot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate labels Oct 6, 2023
@mustafasrepomustafasrepo changed the title [MINOR]: Resolve linter errors[MINOR]: Resolve linter errors in the mainOct 6, 2023

@ozankabakozankabak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@mustafasrepo
mustafasrepo merged commit 8504600 into apache:mainOct 6, 2023
@alamb

alamb commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Thank you @mustafasrepo and @ozankabak

Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Oct 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratelogical-exprLogical plan and expressionsoptimizerOptimizer rulesphysical-exprChanges to the physical-expr cratessqlSQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mustafasrepo@alamb@ozankabak