Skip to content

Fix: Update clippy lints for Rust 1.54 - #794

Merged
Dandandan merged 1 commit into
apache:masterfrom
alamb:alamb/fix_clippy
Jul 29, 2021
Merged

Fix: Update clippy lints for Rust 1.54#794
Dandandan merged 1 commit into
apache:masterfrom
alamb:alamb/fix_clippy

Conversation

@alamb

@alambalamb commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

Rationale:

It's that time again! Rust released 1.54 today which causes some additional clippy errors:

If you run clippy on master after running rustup update you get erros such as the following

error: this expression borrows a reference (`&datafusion::logical_plan::JoinType`) that is immediately dereferenced by the compiler
--> ballista/rust/core/src/serde/physical_plan/mod.rs:108:21
|
108 | &join_type,
| ^^^^^^^^^^ help: change this to: `join_type`
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: aborting due to previous error
error: this expression borrows a reference (`&ballista_core::config::BallistaConfig`) that is immediately dereferenced by the compiler
--> ballista/rust/client/src/context.rs:136:13
|
136 | &guard.config(),
| ^^^^^^^^^^^^^^^ help: change this to: `guard.config()`
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
...

Changes:

  1. Fix clippy errors by doing its suggestions

@Dandandan
Dandandan merged commit 7dde5b1 into apache:masterJul 29, 2021
@Dandandan

Copy link
Copy Markdown
Contributor

Thanks @alamb for fixing it so fast

@alamb

Copy link
Copy Markdown
ContributorAuthor

👍

@alamb
alamb deleted the alamb/fix_clippy branch July 29, 2021 18:31
@alamb

Copy link
Copy Markdown
ContributorAuthor

LOL here is a sister PR for arrow-rs apache/arrow-rs#631

unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb@Dandandan